Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status line info to the submodule list view #3939

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nicklundin08
Copy link

@nicklundin08 nicklundin08 commented Sep 24, 2024

Add status line info to the submodule list view

Adds a QOL status line to the git submodules feature, inspired by the default power level 10k status line. This is a pretty basic first pass that only includes 3 values snagged from running git status --porcelain but I think it could be extended to include all of the values in the table (potentially). See the list view on the left in the submodules pane for the changes

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

lazygitscreenshot

@nicklundin08
Copy link
Author

I'm getting this error intermittently. New to go but unsure what is causing this. Maybe something with my environment? Im using WSL

--- FAIL: TestIntegration/bisect/from_other_branch (0.46s)
go_test.go:51:
Error Trace: /home/nick/clones/lazygit/go_test.go:51
Error: Received unexpected error:
POTENTIAL DEADLOCK: Recursive locking:
current goroutine 2 lock 0xc0000149e0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant