Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter binding label #3968

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VeeDeltaVee
Copy link

@VeeDeltaVee VeeDeltaVee commented Oct 5, 2024

Update the controller (filter_controller.go) to set up the binding to be displayed. Additionally, update the translations for the binding name to be shorter, to make it more likely the text will fit at the bottom of the screen

The keybinding screen in particular (which is a filterable popup) seems frustrating for users. In #3141, @kadaan suggested that perhaps the keybindings page should display a message in the footer about the presence of this option as a way to increase discoverability.

I ran into this issue myself, and figured I'd see if anyone else had implemented some kind of fuzzy finding for the keybindings menu (somewhat like what aerc has). The issue I linked earlier seemed to describe the perfect solution, and it was easy enough to implement. Perhaps in the future the keybinding popup can have special functionality where typing automatically filters, but just having the filter option shown at the bottom seems to me a big improvement.

For reference, here's what the keybindings menu looks like with the change (notice the new "Filter" keybinding hint at the bottom):
image

  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

Update the controller (filter_controller.go) to set up the binding to be
didsplayed. Additionally, update the translations for the binding name
to be shorter, to make it more likely the text will fit at the bottom of
the screen. This also involved updating the keybindings_*.md files with
go generate ./...

The keybinding screen in particular (which is a filterable popup) seems
frustrating for users. In jesseduffield#3141, @kadaan suggested that perhaps the
keybindings page should display a message in the footer about the
presence of this option as a way to increase discoverability.

This change enables this binding displaying on _all_ filterable views.
I'm not sure if it's valuable to restrict this to just the keybinding
view.
@VeeDeltaVee
Copy link
Author

I've marked the adding tests task as unfinished, although I'm not sure if this would even need tests. If it does, please let me know and I'll add some.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant