Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the controller (filter_controller.go) to set up the binding to be displayed. Additionally, update the translations for the binding name to be shorter, to make it more likely the text will fit at the bottom of the screen
The keybinding screen in particular (which is a filterable popup) seems frustrating for users. In #3141, @kadaan suggested that perhaps the keybindings page should display a message in the footer about the presence of this option as a way to increase discoverability.
I ran into this issue myself, and figured I'd see if anyone else had implemented some kind of fuzzy finding for the keybindings menu (somewhat like what
aerc
has). The issue I linked earlier seemed to describe the perfect solution, and it was easy enough to implement. Perhaps in the future the keybinding popup can have special functionality where typing automatically filters, but just having the filter option shown at the bottom seems to me a big improvement.For reference, here's what the keybindings menu looks like with the change (notice the new "Filter" keybinding hint at the bottom):
go generate ./...
)