New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified with more robust steps for Ubuntu/kubuntu installation. #3972

Open

MCT-MIT wants to merge 1 commit into jesseduffield:master from MCT-MIT:mct-ubuntu-steps

MCT-MIT commented Oct 7, 2024

PR Description
Admittedly a minor nit picked.
I modified the "Ubuntu" steps to install the tool along with the README and the LICENCE files so that proper attribution is preserved. This/these changes include setting modes and ownerships instead of relying on environmental values.
Please check if the PR fulfills these requirements

Cheatsheets are up-to-date (run go generate ./...)
Code has been formatted (see here)
Tests have been added/updated (see here for the integration test guide)
Text is internationalised (see here)
If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
Docs have been updated if necessary
You've read through your own file changes for silly mistakes etc


          Modified with more robust steps for Ubuntu/kubuntu installation.

a128b07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet