Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gui.tabWidth config #4291

Merged
merged 3 commits into from
Feb 20, 2025
Merged

Add gui.tabWidth config #4291

merged 3 commits into from
Feb 20, 2025

Conversation

stefanhaller
Copy link
Collaborator

  • PR Description

This adds a config gui.tabWidth that can be used to change the tab width from the default of 4 to a different number. It affects everything that's shown in the main view, but is probably mostly relevant for diffs.

When using a pager, the pager needs to be configured separately for the same tab width.

This may often be different for different repos, so it may make sense to put it in a repo-local config file.

In some cases this may still not be flexible enough, e.g. in multi-language projects that use different tab widths for the different file types; but it's better than before and was easy to do...

Addresses #4290.

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@stefanhaller stefanhaller added the enhancement New feature or request label Feb 19, 2025
Copy link

codacy-production bot commented Feb 19, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 56c9d5a1 90.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (56c9d5a) Report Missing Report Missing Report Missing
Head commit (1161619) 53022 45922 86.61%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4291) 20 18 90.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link
Owner

@jesseduffield jesseduffield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Affects everything that is shown in the main view, but probably mostly relevant
for diffs.
@stefanhaller stefanhaller merged commit 52b1c42 into master Feb 20, 2025
15 checks passed
@stefanhaller stefanhaller deleted the tab-width-config branch February 20, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants