Merge pull request AY2425S1-CS2103T-F15-2#152 from ethan-goh/fix-alph…

…a-bugs Fix Alpha Bugs
jessica2828 · Nov 7, 2024 · a914940 · a914940
2 parents a6c8d1b + 089489a
commit a914940
Show file tree

Hide file tree

Showing 14 changed files with 199 additions and 18 deletions.
diff --git a/src/main/java/seedu/address/logic/commands/DeleteCommand.java b/src/main/java/seedu/address/logic/commands/DeleteCommand.java
@@ -70,6 +70,7 @@ public CommandResult execute(Model model) throws CommandException {
         requireNonNull(model);
         List<Person> lastShownList = model.getFilteredPersonList();
         Person toDelete = null;
+        boolean PersonDetailsDeleted = false;
 
         for (Person person : lastShownList) {
             if (person.getStudentId().equals(studentId)) {
@@ -96,10 +97,28 @@ public CommandResult execute(Model model) throws CommandException {
             }
 
             model.deleteModule(toDelete, moduleToDelete);
+            if (toDelete.isSamePerson(model.getPersonToDisplay())) {
+                for (Person person : lastShownList) {
+                    if (person.getStudentId().equals(studentId)) {
+                        toDelete = person;
+                        break;
+                    }
+                }
+                model.setPersonToDisplay(toDelete);
+                return new CommandResult(String.format(MESSAGE_DELETE_MODULE_SUCCESS, moduleToDelete), true);
+            }
             return new CommandResult(String.format(MESSAGE_DELETE_MODULE_SUCCESS, moduleToDelete));
         }
 
+        if (toDelete.isSamePerson(model.getPersonToDisplay())) {
+            model.setPersonToDisplay(null);
+            PersonDetailsDeleted = true;
+        }
+
         model.deletePerson(toDelete);
+        if (PersonDetailsDeleted) {
+            return new CommandResult(String.format(MESSAGE_DELETE_PERSON_SUCCESS, Messages.format(toDelete)), true);
+        }
         return new CommandResult(String.format(MESSAGE_DELETE_PERSON_SUCCESS, Messages.format(toDelete)));
     }
 

diff --git a/src/main/java/seedu/address/logic/commands/EditCommand.java b/src/main/java/seedu/address/logic/commands/EditCommand.java
@@ -93,8 +93,14 @@ public CommandResult execute(Model model) throws CommandException {
             throw new CommandException(MESSAGE_DUPLICATE_PERSON);
         }
 
+
         model.setPerson(personToEdit, editedPerson);
         model.updateFilteredPersonList(PREDICATE_SHOW_ALL_PERSONS);
+
+        if (personToEdit.isSamePerson(model.getPersonToDisplay())) {
+            model.setPersonToDisplay(editedPerson);
+            return new CommandResult(String.format(MESSAGE_EDIT_PERSON_SUCCESS, Messages.format(editedPerson)), true);
+        }
         return new CommandResult(String.format(MESSAGE_EDIT_PERSON_SUCCESS, Messages.format(editedPerson)));
     }
 
@@ -118,12 +124,12 @@ private static Person createEditedPerson(Person personToEdit, EditPersonDescript
             Module newModule = editPersonDescriptor.newModule;
 
             boolean isModuleRenamed = false;
-            if (updatedModules.stream().anyMatch(m -> m.value.equals(newModule.value))) {
+            if (updatedModules.stream().anyMatch(m -> m.value.toUpperCase().equals(newModule.value.toUpperCase()))) {
                 throw new CommandException(EditCommand.MESSAGE_DUPLICATE_MODULE);
             }
 
             for (int i = 0; i < updatedModules.size(); i++) {
-                if (updatedModules.get(i).value.equals(oldModule.value)) {
+                if (updatedModules.get(i).value.toUpperCase().equals(oldModule.value.toUpperCase())) {
                     Module updatedModule = new Module(newModule.value);
                     if (updatedModules.get(i).hasGrade()) {
                         updatedModule.setGrade(updatedModules.get(i).getGrade());

diff --git a/src/main/java/seedu/address/logic/commands/GradeCommand.java b/src/main/java/seedu/address/logic/commands/GradeCommand.java
@@ -81,6 +81,10 @@ public CommandResult execute(Model model) throws CommandException {
         Person updatedPerson = person.setModuleGrade(module, grade);
         model.setPerson(person, updatedPerson);
         model.updateFilteredPersonList(PREDICATE_SHOW_ALL_PERSONS);
+        if (updatedPerson.isSamePerson(model.getPersonToDisplay())) {
+            model.setPersonToDisplay(updatedPerson);
+            return new CommandResult(String.format(MESSAGE_SUCCESS, module), true);
+        }
         return new CommandResult(String.format(MESSAGE_SUCCESS, module));
     }
 

diff --git a/src/main/java/seedu/address/logic/commands/ModuleCommand.java b/src/main/java/seedu/address/logic/commands/ModuleCommand.java
@@ -75,6 +75,10 @@ public CommandResult execute(Model model) throws CommandException {
         Person updatedPerson = person.addModule(module);
         model.setPerson(person, updatedPerson);
         model.updateFilteredPersonList(PREDICATE_SHOW_ALL_PERSONS);
+        if (updatedPerson.isSamePerson(model.getPersonToDisplay())) {
+            model.setPersonToDisplay(updatedPerson);
+            return new CommandResult(String.format(MESSAGE_SUCCESS, studentId), true);
+        }
         return new CommandResult(String.format(MESSAGE_SUCCESS, studentId));
     }
 

diff --git a/src/main/java/seedu/address/logic/parser/EditCommandParser.java b/src/main/java/seedu/address/logic/parser/EditCommandParser.java
@@ -47,7 +47,8 @@ public EditCommand parse(String args) throws ParseException {
             if (modules.length != 2) {
                 throw new ParseException(String.format(MESSAGE_INVALID_COMMAND_FORMAT, EditCommand.MESSAGE_USAGE));
             }
-            editPersonDescriptor.setModuleChanges(new Module(modules[0].toUpperCase()), new Module(modules[1]));
+            editPersonDescriptor.setModuleChanges(new Module(modules[0].toUpperCase()),
+                    new Module(modules[1].toUpperCase()));
         } else {
             if (argMultimap.getValue(PREFIX_NAME).isPresent()) {
                 editPersonDescriptor.setName(ParserUtil.parseName(argMultimap.getValue(PREFIX_NAME).get()

diff --git a/src/main/java/seedu/address/logic/parser/ModuleCommandParser.java b/src/main/java/seedu/address/logic/parser/ModuleCommandParser.java
@@ -32,7 +32,7 @@ public ModuleCommand parse(String args) throws ParseException {
         argMultimap.verifyNoDuplicatePrefixesFor(PREFIX_MODULE);
         argMultimap.verifyNoDuplicateStudentId(args);
         StudentId studentId = ParserUtil.parseStudentId(preamble);
-        Module module = ParserUtil.parseModule(argMultimap.getValue(PREFIX_MODULE).get().toUpperCase());
+        Module module = ParserUtil.parseModule(argMultimap.getValue(PREFIX_MODULE).get());
 
         return new ModuleCommand(studentId, module);
     }

diff --git a/src/main/java/seedu/address/logic/parser/ParserUtil.java b/src/main/java/seedu/address/logic/parser/ParserUtil.java
@@ -66,6 +66,7 @@ public static Name parseName(String name) throws ParseException {
         if (!Name.isValidName(trimmedName)) {
             throw new ParseException(Name.MESSAGE_CONSTRAINTS);
         }
+        trimmedName = makeCapitalise(trimmedName);
         return new Name(trimmedName);
     }
 
@@ -96,6 +97,7 @@ public static Address parseAddress(String address) throws ParseException {
         if (!Address.isValidAddress(trimmedAddress)) {
             throw new ParseException(Address.MESSAGE_CONSTRAINTS);
         }
+        trimmedAddress = makeUppercase(trimmedAddress);
         return new Address(trimmedAddress);
     }
 
@@ -111,6 +113,7 @@ public static Email parseEmail(String email) throws ParseException {
         if (!Email.isValidEmail(trimmedEmail)) {
             throw new ParseException(Email.MESSAGE_CONSTRAINTS);
         }
+        trimmedEmail = makeLowercase(trimmedEmail);
         return new Email(trimmedEmail);
     }
 
@@ -126,6 +129,7 @@ public static Tag parseTag(String tag) throws ParseException {
         if (!Tag.isValidTag(trimmedTag)) {
             throw new ParseException(Tag.MESSAGE_CONSTRAINTS);
         }
+        trimmedTag = makeCapitalise(trimmedTag);
         return new Tag(trimmedTag);
     }
 
@@ -153,6 +157,7 @@ public static Course parseCourse(String course) throws ParseException {
         if (!Course.isValidCourse(trimmedCourse)) {
             throw new ParseException(Course.MESSAGE_CONSTRAINTS);
         }
+        trimmedCourse = makeCapitalise(trimmedCourse);
         return new Course(trimmedCourse);
     }
 
@@ -168,6 +173,7 @@ public static Module parseModule(String module) throws ParseException {
         if (!Module.isValidModule(trimmedModule)) {
             throw new ParseException(Module.MESSAGE_CONSTRAINTS);
         }
+        trimmedModule = makeUppercase(trimmedModule);
         return new Module(trimmedModule);
     }
 
@@ -183,6 +189,43 @@ public static Grade parseGrade(String grade) throws ParseException {
         if (!Grade.isValidGrade(trimmedGrade)) {
             throw new ParseException(Grade.MESSAGE_CONSTRAINTS);
         }
+        trimmedGrade = makeUppercase(trimmedGrade);
         return new Grade(trimmedGrade);
     }
+
+    /**
+     * Capitalizes the first letter of each word in the given input string
+     * and converts all other letters to lowercase.
+     *
+     * This method splits the input string by spaces, then processes each word
+     * to ensure that the first character is uppercase while the remaining characters
+     * are lowercase. The modified words are then joined back into a single string.
+     *
+     * @param input The input string to be capitalized. Each word's first letter will be capitalized,
+     *              and the remaining letters will be in lowercase.
+     * @return A string with the first letter of each word capitalized and the rest in lowercase.
+     *         Leading and trailing whitespace is removed.
+     */
+    public static String makeCapitalise(String input) {
+        String[] words = input.split(" ");
+        StringBuilder capitalised = new StringBuilder();
+
+        for (String word : words) {
+            if (!word.isEmpty()) {
+                capitalised.append(Character.toUpperCase(word.charAt(0)))
+                        .append(word.substring(1).toLowerCase())
+                        .append(" ");
+            }
+        }
+
+        return capitalised.toString().trim();
+    }
+
+    public static String makeUppercase(String input) {
+        return input.toUpperCase();
+    }
+
+    public static String makeLowercase(String input) {
+        return input.toLowerCase();
+    }
 }
diff --git a/src/main/java/seedu/address/model/ModelManager.java b/src/main/java/seedu/address/model/ModelManager.java
@@ -144,7 +144,6 @@ public void setPerson(Person target, Person editedPerson) {
         requireAllNonNull(target, editedPerson);
 
         eduContacts.setPerson(target, editedPerson);
-        setPersonToDisplay(editedPerson);
     }
 
     //=========== Filtered Person List Accessors =============================================================

diff --git a/src/main/java/seedu/address/ui/PersonDetails.java b/src/main/java/seedu/address/ui/PersonDetails.java
@@ -93,6 +93,12 @@ public void updateDetails(Person person) {
             tag.setText("");
             course.setText("");
             module.setText("");
+            profileImage.setVisible(false);
+            studentIdHeader.setVisible(false);
+            contactHeader.setVisible(false);
+            addressHeader.setVisible(false);
+            emailHeader.setVisible(false);
+            moduleHeader.setVisible(false);
         }
     }
 }
diff --git a/src/main/java/seedu/address/ui/PersonListPanel.java b/src/main/java/seedu/address/ui/PersonListPanel.java
@@ -40,6 +40,7 @@ protected void updateItem(Person person, boolean empty) {
             if (empty || person == null) {
                 setGraphic(null);
                 setText(null);
+                setStyle("-fx-background-color: white;");
             } else {
                 setGraphic(new PersonCard(person, getIndex() + 1).getRoot());
             }

diff --git a/src/test/java/seedu/address/logic/commands/DeleteCommandTest.java b/src/test/java/seedu/address/logic/commands/DeleteCommandTest.java
@@ -187,6 +187,45 @@ public void execute_invalidStudentIdWithModule_throwsCommandException() {
                 deleteCommand, model, String.format(DeleteCommand.MESSAGE_PERSON_NOT_FOUND, invalidStudentId));
     }
 
+    @Test
+    public void execute_deleteModuleWhenPersonDisplayed_success() {
+        Person personToDisplay = model.getFilteredPersonList().get(INDEX_FIRST_PERSON.getZeroBased());
+        model.setPersonToDisplay(personToDisplay);
+
+        Module moduleToDelete = new Module("CS2103T");
+        Person updatedPerson = personToDisplay.addModule(moduleToDelete);
+        model.setPerson(personToDisplay, updatedPerson);
+
+        DeleteCommand deleteCommand = new DeleteCommand(personToDisplay.getStudentId(), moduleToDelete);
+
+        String expectedMessage = String.format(DeleteCommand.MESSAGE_DELETE_MODULE_SUCCESS, moduleToDelete.toString());
+
+        ModelManager expectedModel = new ModelManager(model.getEduContacts(), new UserPrefs(), personToDisplay);
+        expectedModel.deleteModule(updatedPerson, moduleToDelete);
+        assertCommandSuccess(deleteCommand, model, expectedMessage, expectedModel);
+    }
+
+    @Test
+    public void execute_deleteModuleWhenPersonNotDisplayed_success() {
+        Person personToDelete = model.getFilteredPersonList().get(INDEX_FIRST_PERSON.getZeroBased());
+        Person personToDisplay = model.getFilteredPersonList().get(INDEX_SECOND_PERSON.getZeroBased());
+
+        model.setPersonToDisplay(personToDisplay);
+
+        Module moduleToDelete = new Module("CS2103T");
+        Person updatedPerson = personToDelete.addModule(moduleToDelete);
+        model.setPerson(personToDelete, updatedPerson);
+
+        DeleteCommand deleteCommand = new DeleteCommand(personToDelete.getStudentId(), moduleToDelete);
+
+        String expectedMessage = String.format(DeleteCommand.MESSAGE_DELETE_MODULE_SUCCESS, moduleToDelete.toString());
+
+        ModelManager expectedModel = new ModelManager(model.getEduContacts(), new UserPrefs(), personToDisplay);
+        expectedModel.deleteModule(updatedPerson, moduleToDelete);
+
+        assertCommandSuccess(deleteCommand, model, expectedMessage, expectedModel);
+    }
+
     @Test
     public void execute_deleteGradedModule_success() {
         Person personWithModule = model.getFilteredPersonList().get(INDEX_FIRST_PERSON.getZeroBased());
@@ -200,6 +239,7 @@ public void execute_deleteGradedModule_success() {
         ModelManager expectedModel = new ModelManager(model.getEduContacts(), new UserPrefs());
         expectedModel.deleteModule(personWithModule, moduleToDelete);
 
+
         assertCommandSuccess(deleteCommand, model, expectedMessage, expectedModel);
     }
 

diff --git a/src/test/java/seedu/address/logic/commands/EditCommandTest.java b/src/test/java/seedu/address/logic/commands/EditCommandTest.java
@@ -175,19 +175,6 @@ public void execute_someFieldsSpecifiedUnfilteredList_success() {
         assertCommandSuccess(editCommand, model, expectedMessage, expectedModel);
     }
 
-    @Test
-    public void execute_noFieldSpecifiedUnfilteredList_success() {
-        StudentId studentId = model.getFilteredPersonList().get(0).getStudentId();
-        EditCommand editCommand = new EditCommand(studentId, new EditPersonDescriptor());
-        Person editedPerson = model.getFilteredPersonList().get(INDEX_FIRST_PERSON.getZeroBased());
-
-        String expectedMessage = String.format(EditCommand.MESSAGE_EDIT_PERSON_SUCCESS, Messages.format(editedPerson));
-
-        Model expectedModel = new ModelManager(new EduContacts(model.getEduContacts()), new UserPrefs(), editedPerson);
-
-        assertCommandSuccess(editCommand, model, expectedMessage, expectedModel);
-    }
-
     @Test
     public void execute_filteredList_success() {
         showPersonAtIndex(model, INDEX_FIRST_PERSON);
@@ -231,6 +218,35 @@ public void execute_invalidPersonIndexFilteredList_failure() {
         assertCommandFailure(editCommand, model, Messages.MESSAGE_INVALID_PERSON_DISPLAYED_STUDENTID);
     }
 
+    @Test
+    public void execute_personDisplayedEdited_success() throws CommandException {
+
+        Person personToDisplay = model.getFilteredPersonList().get(INDEX_FIRST_PERSON.getZeroBased());
+        model.setPersonToDisplay(personToDisplay);
+
+        EditPersonDescriptor descriptor = new EditPersonDescriptorBuilder()
+                .withName("Edited Name")
+                .withPhone("98765432")
+                .withEmail("[email protected]")
+                .build();
+
+        EditCommand editCommand = new EditCommand(personToDisplay.getStudentId(), descriptor);
+
+        Person editedPerson = new PersonBuilder(personToDisplay)
+                .withName("Edited Name")
+                .withPhone("98765432")
+                .withEmail("[email protected]")
+                .build();
+
+        String expectedMessage = String.format(EditCommand.MESSAGE_EDIT_PERSON_SUCCESS, Messages.format(editedPerson));
+
+        Model expectedModel = new ModelManager(model.getEduContacts(), new UserPrefs());
+        expectedModel.setPerson(personToDisplay, editedPerson);
+        expectedModel.setPersonToDisplay(editedPerson);
+
+        assertCommandSuccess(editCommand, model, expectedMessage, expectedModel);
+    }
+
     @Test
     public void equals() {
         StudentId firstPersonId = model.getFilteredPersonList().get(0).getStudentId();

diff --git a/src/test/java/seedu/address/logic/commands/GradeCommandTest.java b/src/test/java/seedu/address/logic/commands/GradeCommandTest.java
@@ -11,6 +11,7 @@
 import static seedu.address.logic.commands.CommandTestUtil.VALID_STUDENTID_BOB;
 import static seedu.address.logic.commands.CommandTestUtil.assertCommandSuccess;
 import static seedu.address.testutil.Assert.assertThrows;
+import static seedu.address.testutil.TypicalIndexes.INDEX_FIRST_PERSON;
 import static seedu.address.testutil.TypicalPersons.getTypicalEduContacts;
 
 import org.junit.jupiter.api.Test;
@@ -79,6 +80,28 @@ public void execute_moduleNotFound_throwsCommandException() {
                         -> gradeCommand.execute(model));
     }
 
+    @Test
+    public void execute_gradeAddedWhenPersonDisplayed_success() {
+        Person personToAddGrade = model.getFilteredPersonList().get(INDEX_FIRST_PERSON.getZeroBased());
+        Person expectedStudent = new PersonBuilder(personToAddGrade).build();
+
+        Module validModule = new Module(VALID_MODULE_AMY);
+        Grade validGrade = new Grade(VALID_GRADE_AMY);
+        Person newPerson = personToAddGrade.addModule(validModule);
+        model.setPerson(model.getFilteredPersonList().get(INDEX_FIRST_PERSON.getZeroBased()), newPerson);
+        expectedStudent = expectedStudent.addModule(validModule);
+        expectedStudent = expectedStudent.setModuleGrade(validModule, validGrade);
+        GradeCommand gradeCommand = new GradeCommand(personToAddGrade.getStudentId(), validModule, validGrade);
+        model.setPersonToDisplay(expectedStudent);
+        String expectedMessage = String.format(GradeCommand.MESSAGE_SUCCESS, validModule);
+
+        Model expectedModel = new ModelManager(new EduContacts(model.getEduContacts()),
+                new UserPrefs(), expectedStudent);
+        expectedModel.setPerson(model.getFilteredPersonList().get(INDEX_FIRST_PERSON.getZeroBased()), expectedStudent);
+
+        assertCommandSuccess(gradeCommand, model, expectedMessage, expectedModel);
+    }
+
     @Test
     public void equals() {
         StudentId amyId = new StudentId(VALID_STUDENTID_AMY);