Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update resolve #14358

Closed
wants to merge 2 commits into from
Closed

chore: update resolve #14358

wants to merge 2 commits into from

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jul 25, 2023

Summary

Following up #14356.

inspect-js/is-core-module#14 would also work, but since the change only affects a single test where we do weird stuff with path mocking, I think this is fine.

Test plan

Green CI

@netlify
Copy link

netlify bot commented Jul 25, 2023

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2c4a309
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/64bf874534ecad0008e6ecf9
😎 Deploy Preview https://deploy-preview-14358--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SimenB
Copy link
Member Author

SimenB commented Oct 2, 2023

#14516 updated this to 1.22.4, which works out of the box 🤷

Oh: browserify/resolve#297 (comment)

@SimenB SimenB closed this Oct 2, 2023
@SimenB SimenB deleted the update-resolve branch October 2, 2023 11:38
Copy link

github-actions bot commented Nov 2, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant