Skip to content

Commit

Permalink
chore: fix ls-engines
Browse files Browse the repository at this point in the history
Ok, so this one is complicated.
SemVer wise, we should be able to support glob 10 & glob 11.
The only breaking change is the engine.
Therefore, the "correct" specifier is indeed `^10.2.6 || ^11.0.0`.
We support both, if you need an older engine,
you should use an older version.
In fact, npm is supposed to do this automatically.
However, up until `[email protected]` (included in `[email protected]`),
there was a longstanding bug where it didn't!
The code was there,
but the logic didn't work right and after Isaacs moved on to vlt,
his PR fixing this got stalled.
After the `glob` fiasco, he rebased the PR and it's now fixed,
but the change wasn't backported.
Because we support Node 14, we support `[email protected]`,
so we can't take advantage of this.
Instead, we just have to tolerate a slightly old version of glob.
Oh well.

I also removed "enginesStrict" because our engine declaration is now higher than technically needed
because glob only declares support for the latest versions of Node branches.
  • Loading branch information
lishaduck committed Sep 4, 2024
1 parent d185590 commit b38cf28
Show file tree
Hide file tree
Showing 2 changed files with 7,248 additions and 8,741 deletions.
Loading

0 comments on commit b38cf28

Please sign in to comment.