Skip to content

Commit

Permalink
chore: fix ls-engines
Browse files Browse the repository at this point in the history
Ok, so this one is complicated.
SemVer wise, we should be able to support glob 10 & glob 11.
The only breaking change is the engine.
Therefore, the "correct" specifier is indeed `^10.2.6 || ^11.0.0`.
We support both, if you need an older engine,
you should use an older version.
In fact, npm is supposed to do this automatically.
However, up until `[email protected]` (included in `[email protected]`),
there was a longstanding bug where it didn't!
The code was there,
but the logic didn't work right and after Isaacs moved on to vlt,
his PR fixing this got stalled.
After the `glob` fiasco, he rebased the PR and it's now fixed,
but the change wasn't backported.
Because we support Node 14, we support `[email protected]`,
so we can't take advantage of this.
Instead, we just have to tolerate a slightly old version of glob.
Oh well.

I also removed "enginesStrict" again
because our engine declaration is now higher than technically needed
because `glob` only declares support for the latest versions of Node branches.
  • Loading branch information
lishaduck authored and jfmengels committed Oct 29, 2024
1 parent 2bcab63 commit f7b941c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
"find-up": "^4.1.0 || ^5.0.0",
"folder-hash": "^3.3.0",
"fs-extra": "^9.0.0",
"glob": "^10.2.6 || ^11.0.0",
"glob": "^10.2.6",
"globby": "^13.2.2",
"got": "^11.8.5",
"graceful-fs": "^4.2.11",
Expand Down Expand Up @@ -116,6 +116,5 @@
"packageManager": "[email protected]",
"engines": {
"node": "14 >=14.21 || 16 >=16.20 || 18 || 20 || >=22"
},
"enginesStrict": true
}
}

0 comments on commit f7b941c

Please sign in to comment.