Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump deps #256

Merged
merged 12 commits into from
Oct 28, 2024
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"elm-tests": "(cd template/ && elm make src/Elm/Review/Main.elm --output=/dev/null && elm-test)",
"eslint-check": "eslint . --report-unused-disable-directives --max-warnings=0",
"eslint-fix": "npm run eslint-check -- --fix",
"jest": "npx jest",
"jest": "jest",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong commit, but doesn't make any behavioral change beyond shaving a few milliseconds off testing.

"prepare": "elm-tooling install",
"prettier-check": "prettier . --check",
"prettier-fix": "prettier . --write",
Expand Down
2 changes: 0 additions & 2 deletions test/project-using-es2015-module/review/src/ReviewConfig.elm
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ when inside the directory containing this file.
import NoUnused.CustomTypeConstructors
import NoUnused.Dependencies
import NoUnused.Exports
import NoUnused.Modules
import NoUnused.Parameters
import NoUnused.Patterns
import NoUnused.Variables
Expand All @@ -26,7 +25,6 @@ config =
[ NoUnused.CustomTypeConstructors.rule []
, NoUnused.Dependencies.rule
, NoUnused.Exports.rule
, NoUnused.Modules.rule
, NoUnused.Parameters.rule
, NoUnused.Patterns.rule
, NoUnused.Variables.rule
Expand Down
2 changes: 0 additions & 2 deletions test/project-with-errors/review/src/ReviewConfig.elm
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ when inside the directory containing this file.
import NoUnused.CustomTypeConstructors
import NoUnused.Dependencies
import NoUnused.Exports
import NoUnused.Modules
import NoUnused.Parameters
import NoUnused.Patterns
import NoUnused.Variables
Expand All @@ -26,7 +25,6 @@ config =
[ NoUnused.CustomTypeConstructors.rule []
, NoUnused.Dependencies.rule
, NoUnused.Exports.rule
, NoUnused.Modules.rule
, NoUnused.Parameters.rule
, NoUnused.Patterns.rule
, NoUnused.Variables.rule
Expand Down
2 changes: 1 addition & 1 deletion test/run-snapshots/filter-rules-comma.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
-- ELM-REVIEW ERROR ---------------------------------- src/Folder/Unused.elm:1:8

NoUnused.Modules: Module `Folder.Unused` is never used.
NoUnused.Exports: Module `Folder.Unused` is never used.

1| module Folder.Unused exposing (..)
^^^^^^^^^^^^^
Expand Down
4 changes: 2 additions & 2 deletions test/run-snapshots/filter-rules-json.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
{
"rule": "NoUnused.Variables",
"message": "Imported variable `span` is not used",
"ruleLink": "https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.1.8/NoUnused-Variables",
"ruleLink": "https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.2.3/NoUnused-Variables",
"details": [
"You should either use this value somewhere, or remove it at the location I pointed at."
],
Expand Down Expand Up @@ -44,7 +44,7 @@
{
"string": "NoUnused.Variables",
"color": "#FF0000",
"href": "https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.1.8/NoUnused-Variables"
"href": "https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.2.3/NoUnused-Variables"
},
": Imported variable `span` is not used\n\n10| -- span is unused\n11| , span\n ",
{
Expand Down
2 changes: 1 addition & 1 deletion test/run-snapshots/filter-rules-multiple-calls.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
-- ELM-REVIEW ERROR ---------------------------------- src/Folder/Unused.elm:1:8

NoUnused.Modules: Module `Folder.Unused` is never used.
NoUnused.Exports: Module `Folder.Unused` is never used.

1| module Folder.Unused exposing (..)
^^^^^^^^^^^^^
Expand Down
2 changes: 1 addition & 1 deletion test/run-snapshots/filter-rules-ndjson.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"path":"src/Main.elm","rule":"NoUnused.Variables","message":"Imported variable `span` is not used","ruleLink":"https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.1.8/NoUnused-Variables","details":["You should either use this value somewhere, or remove it at the location I pointed at."],"region":{"start":{"line":11,"column":11},"end":{"line":11,"column":15}},"fix":[{"range":{"start":{"line":9,"column":14},"end":{"line":11,"column":15}},"string":""}],"formatted":[{"string":"(fix) ","color":"#33BBC8"},{"string":"NoUnused.Variables","color":"#FF0000","href":"https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.1.8/NoUnused-Variables"},": Imported variable `span` is not used\n\n10| -- span is unused\n11| , span\n ",{"string":"^^^^","color":"#FF0000"},"\n12| , text\n\nYou should either use this value somewhere, or remove it at the location I pointed at."],"suppressed":false,"originallySuppressed":false}
{"path":"src/Main.elm","rule":"NoUnused.Variables","message":"Imported variable `span` is not used","ruleLink":"https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.2.3/NoUnused-Variables","details":["You should either use this value somewhere, or remove it at the location I pointed at."],"region":{"start":{"line":11,"column":11},"end":{"line":11,"column":15}},"fix":[{"range":{"start":{"line":9,"column":14},"end":{"line":11,"column":15}},"string":""}],"formatted":[{"string":"(fix) ","color":"#33BBC8"},{"string":"NoUnused.Variables","color":"#FF0000","href":"https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.2.3/NoUnused-Variables"},": Imported variable `span` is not used\n\n10| -- span is unused\n11| , span\n ",{"string":"^^^^","color":"#FF0000"},"\n12| , text\n\nYou should either use this value somewhere, or remove it at the location I pointed at."],"suppressed":false,"originallySuppressed":false}
2 changes: 1 addition & 1 deletion test/run-snapshots/filter-unknown-rule-json.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
"title": "UNKNOWN FILTERED RULE(S)",
"path": "<local-path>/test/project-with-errors/review/elm.json",
"message": [
"You requested to only run several rules, but I could not find some of them.\n\n- NoUnused.Unknown. Did you mean:\n - NoUnused.Exports\n - NoUnused.Modules\n - NoUnused.Patterns"
"You requested to only run several rules, but I could not find some of them.\n\n- NoUnused.Unknown. Did you mean:\n - NoUnused.Exports\n - NoUnused.Patterns\n - NoUnused.Variables"
]
}
2 changes: 1 addition & 1 deletion test/run-snapshots/filter-unknown-rule-ndjson.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
"title": "UNKNOWN FILTERED RULE(S)",
"path": "<local-path>/test/project-with-errors/review/elm.json",
"message": [
"You requested to only run several rules, but I could not find some of them.\n\n- NoUnused.Unknown. Did you mean:\n - NoUnused.Exports\n - NoUnused.Modules\n - NoUnused.Patterns"
"You requested to only run several rules, but I could not find some of them.\n\n- NoUnused.Unknown. Did you mean:\n - NoUnused.Exports\n - NoUnused.Patterns\n - NoUnused.Variables"
]
}
2 changes: 1 addition & 1 deletion test/run-snapshots/filter-unknown-rule.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ You requested to only run several rules, but I could not find some of them.

- NoUnused.Unknown. Did you mean:
- NoUnused.Exports
- NoUnused.Modules
- NoUnused.Patterns
- NoUnused.Variables

21 changes: 2 additions & 19 deletions test/run-snapshots/fix-all.txt
Original file line number Diff line number Diff line change
@@ -1,28 +1,11 @@
-- ELM-REVIEW ERROR ---------------------------------- src/Folder/Unused.elm:1:8

NoUnused.Modules: Module `Folder.Unused` is never used.
NoUnused.Exports: Module `Folder.Unused` is never used.

1| module Folder.Unused exposing (..)
^^^^^^^^^^^^^

This module is never used. You may want to remove it to keep your project clean,
and maybe detect some unused code in your project.

src/Folder/Unused.elm ↑
====o======================================================================o====
↓ src/Main.elm


-- ELM-REVIEW ERROR ------------------------------------------ src/Main.elm:27:7

NoUnused.CustomTypeConstructors: Type constructor `UnusedCustomType` is not
used.

26| | Decrement
27| | UnusedCustomType
^^^^^^^^^^^^^^^^

This type constructor is never used. It might be handled everywhere it might
appear, but there is no location where this value actually gets created.

I found 2 errors in 2 files.
I found 1 error in 1 file.
4 changes: 2 additions & 2 deletions test/run-snapshots/ignore-dirs.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ pointed at.

────────────────────────────────────────────────────────────── src/Main.elm:29:7

NoUnused.CustomTypeConstructors: Type constructor `UnusedCustomType` is not
used.
(fix) NoUnused.CustomTypeConstructors: Type constructor `UnusedCustomType` is
not used.

28| | Decrement
29| | UnusedCustomType
Expand Down
4 changes: 2 additions & 2 deletions test/run-snapshots/ignore-files.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ pointed at.

────────────────────────────────────────────────────────────── src/Main.elm:29:7

NoUnused.CustomTypeConstructors: Type constructor `UnusedCustomType` is not
used.
(fix) NoUnused.CustomTypeConstructors: Type constructor `UnusedCustomType` is
not used.

28| | Decrement
29| | UnusedCustomType
Expand Down
2 changes: 0 additions & 2 deletions test/run-snapshots/project to fix/review/src/ReviewConfig.elm
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ when inside the directory containing this file.
import NoUnused.CustomTypeConstructors
import NoUnused.Dependencies
import NoUnused.Exports
import NoUnused.Modules
import NoUnused.Parameters
import NoUnused.Patterns
import NoUnused.Variables
Expand All @@ -26,7 +25,6 @@ config =
[ NoUnused.CustomTypeConstructors.rule []
, NoUnused.Dependencies.rule
, NoUnused.Exports.rule
, NoUnused.Modules.rule
, NoUnused.Parameters.rule
, NoUnused.Patterns.rule
, NoUnused.Variables.rule
Expand Down
4 changes: 0 additions & 4 deletions test/run-snapshots/project to fix/src/Main.elm
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ initialModel =
type Msg
= Increment
| Decrement
| UnusedCustomType


update : Msg -> Model -> Model
Expand All @@ -36,9 +35,6 @@ update msg model =
Decrement ->
{ model | count = model.count - 1 }

UnusedCustomType ->
model


view : Model -> Html Msg
view model =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
{
"rule": "NoUnused.Variables",
"message": "Imported variable `h1` is not used",
"ruleLink": "https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.1.29/NoUnused-Variables",
"ruleLink": "https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.2.3/NoUnused-Variables",
"details": [
"You should either use this value somewhere, or remove it at the location I pointed at."
],
Expand Down Expand Up @@ -48,7 +48,7 @@
{
"string": "NoUnused.Variables",
"color": "#FF0000",
"href": "https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.1.29/NoUnused-Variables"
"href": "https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.2.3/NoUnused-Variables"
},
": Imported variable `h1` is not used\n\n10| , -- h1 is unused\n11| h1\n ",
{
Expand All @@ -63,7 +63,7 @@
{
"rule": "NoUnused.Variables",
"message": "Imported variable `span` is not used",
"ruleLink": "https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.1.29/NoUnused-Variables",
"ruleLink": "https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.2.3/NoUnused-Variables",
"details": [
"You should either use this value somewhere, or remove it at the location I pointed at."
],
Expand Down Expand Up @@ -104,7 +104,7 @@
{
"string": "NoUnused.Variables",
"color": "#FF0000",
"href": "https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.1.29/NoUnused-Variables"
"href": "https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.2.3/NoUnused-Variables"
},
": Imported variable `span` is not used\n\n12| , -- span is unused\n13| span\n ",
{
Expand All @@ -124,7 +124,7 @@
{
"rule": "NoUnused.Variables",
"message": "Top-level variable `b` is not used",
"ruleLink": "https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.1.29/NoUnused-Variables",
"ruleLink": "https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.2.3/NoUnused-Variables",
"details": [
"You should either use this value somewhere, or remove it at the location I pointed at."
],
Expand Down Expand Up @@ -165,7 +165,7 @@
{
"string": "NoUnused.Variables",
"color": "#FF0000",
"href": "https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.1.29/NoUnused-Variables"
"href": "https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.2.3/NoUnused-Variables"
},
": Top-level variable `b` is not used\n\n8| b =\n ",
{
Expand All @@ -180,7 +180,7 @@
{
"rule": "NoUnused.Variables",
"message": "Top-level variable `c` is not used",
"ruleLink": "https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.1.29/NoUnused-Variables",
"ruleLink": "https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.2.3/NoUnused-Variables",
"details": [
"You should either use this value somewhere, or remove it at the location I pointed at."
],
Expand Down Expand Up @@ -221,7 +221,7 @@
{
"string": "NoUnused.Variables",
"color": "#FF0000",
"href": "https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.1.29/NoUnused-Variables"
"href": "https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.2.3/NoUnused-Variables"
},
": Top-level variable `c` is not used\n\n12| c =\n ",
{
Expand All @@ -241,7 +241,7 @@
{
"rule": "NoUnused.Dependencies",
"message": "Unused dependency `elm/time`",
"ruleLink": "https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.1.29/NoUnused-Dependencies",
"ruleLink": "https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.2.3/NoUnused-Dependencies",
"details": [
"To remove it, I recommend running the following command:",
" elm-json uninstall elm/time"
Expand All @@ -268,7 +268,7 @@
"column": 1
}
},
"string": "{\n \"type\": \"application\",\n \"source-directories\": [\n \"src\"\n ],\n \"elm-version\": \"0.19.1\",\n \"dependencies\": {\n \"direct\": {\n \"elm/browser\": \"1.0.2\",\n \"elm/core\": \"1.0.5\",\n \"elm/html\": \"1.0.0\"\n },\n \"indirect\": {\n \"elm/json\": \"1.1.3\",\n \"elm/time\": \"1.0.0\",\n \"elm/url\": \"1.0.0\",\n \"elm/virtual-dom\": \"1.0.2\"\n }\n },\n \"test-dependencies\": {\n \"direct\": {},\n \"indirect\": {}\n }\n}\n"
"string": "{\n \"type\": \"application\",\n \"source-directories\": [\n \"src\"\n ],\n \"elm-version\": \"0.19.1\",\n \"dependencies\": {\n \"direct\": {\n \"elm/browser\": \"1.0.2\",\n \"elm/core\": \"1.0.5\",\n \"elm/html\": \"1.0.0\"\n },\n \"indirect\": {\n \"elm/json\": \"1.1.3\",\n \"elm/time\": \"1.0.0\",\n \"elm/url\": \"1.0.0\",\n \"elm/virtual-dom\": \"1.0.3\"\n }\n },\n \"test-dependencies\": {\n \"direct\": {},\n \"indirect\": {}\n }\n}\n"
}
],
"formatted": [
Expand All @@ -283,7 +283,7 @@
{
"string": "NoUnused.Dependencies",
"color": "#FF0000",
"href": "https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.1.29/NoUnused-Dependencies"
"href": "https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.2.3/NoUnused-Dependencies"
},
": Unused dependency `elm/time`\n\n11| \"elm/html\": \"1.0.0\",\n12| \"elm/time\": \"1.0.0\"\n ",
{
Expand Down
Loading