Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set esModuleInterop to true #322

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

lishaduck
Copy link
Contributor

I turned it off a while ago, but it should be on. It's allowSyntheticDefaultImports that should be off.

I turned it off a while ago, but it should be on.
It's `allowSyntheticDefaultImports` that should be off.
Copy link
Contributor Author

@lishaduck lishaduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, ran the following the my terminal twice, no flakes at all:

for ((i=1; i<=5; i++)); do
turbo --ui=stream --force=true jest
done

Makes me wonder if the flake is Linux-exclusiveish. I know I reproed it locally a while ago, but I can't seem to anymore.

@jfmengels
Copy link
Owner

Hmm possible. I managed to recreate similar flakes locally (Linux Ubuntu).

@jfmengels
Copy link
Owner

I was only able to recreate it by having multiple terminals running jest. So maybe it's because two tests try to compile the same application at the same time? 🤔

@lishaduck
Copy link
Contributor Author

I was only able to recreate it by having multiple terminals running jest. So maybe it's because two tests try to compile the same application at the same time? 🤔

Hmm, that'd explain #319, as elm-pages has a lot of race conditions (I hear it's a lot better nowadays, so maybe not).
However, Jest tests don't run in parallel, do they? Oh... e2e tests and jest tests run in parallel... I'll try reverting that :)

@lishaduck
Copy link
Contributor Author

I was only able to recreate it by having multiple terminals running jest. So maybe it's because two tests try to compile the same application at the same time? 🤔

I, too, can repro it locally like that.

@lishaduck
Copy link
Contributor Author

lishaduck commented Dec 3, 2024

Disappointing, but I guess I just means I need to find the time to do that refactor of options parsing that'll let us quit spawning processes. (And I guess the caching issues was probably actually this too)

At some point, it'd probably also be good to do some form of file locking or something to handle concurrent modifications better, but on the other hand, I suppose we sorta do, with the --namespace option, but I don't see how we could get that set in tests.

@lishaduck
Copy link
Contributor Author

@jfmengels, do you want me to file an issue for supporting concurrent elm-review runs?

@jfmengels
Copy link
Owner

Yeah, the namespace option was meant for that. Though it's also a shame to need that, as that means that a cache for the CLI would not get used by an editor and vice versa. If we could get rid of it that would actually be nice I think.

@lishaduck opening an issue would be great 👍

@jfmengels jfmengels merged commit b4edb69 into jfmengels:main Dec 4, 2024
1 check passed
@lishaduck lishaduck deleted the es-mod-interop branch December 4, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants