-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set esModuleInterop
to true
#322
Conversation
I turned it off a while ago, but it should be on. It's `allowSyntheticDefaultImports` that should be off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, ran the following the my terminal twice, no flakes at all:
for ((i=1; i<=5; i++)); do
turbo --ui=stream --force=true jest
done
Makes me wonder if the flake is Linux-exclusiveish. I know I reproed it locally a while ago, but I can't seem to anymore.
Hmm possible. I managed to recreate similar flakes locally (Linux Ubuntu). |
I was only able to recreate it by having multiple terminals running |
Hmm, that'd explain #319, as |
8f34b65
to
dc41c49
Compare
I, too, can repro it locally like that. |
dc41c49
to
401314f
Compare
Disappointing, but I guess I just means I need to find the time to do that refactor of options parsing that'll let us quit spawning processes. (And I guess the caching issues was probably actually this too) At some point, it'd probably also be good to do some form of file locking or something to handle concurrent modifications better, but on the other hand, I suppose we sorta do, with the |
@jfmengels, do you want me to file an issue for supporting concurrent |
Yeah, the namespace option was meant for that. Though it's also a shame to need that, as that means that a cache for the CLI would not get used by an editor and vice versa. If we could get rid of it that would actually be nice I think. @lishaduck opening an issue would be great 👍 |
I turned it off a while ago, but it should be on. It's
allowSyntheticDefaultImports
that should be off.