Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing cached JFrog CLI path on cleanup task #197

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Fix missing cached JFrog CLI path on cleanup task #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,8 @@ class Utils {
if (jfExecDir && jfrogExecDir) {
core.addPath(jfExecDir);
core.addPath(jfrogExecDir);
// Save the JF CLI path to use on cleanup. saveState/getState are methods to pass data between a step, and it's cleanup function.
core.saveState(Utils.JF_CLI_PATH_STATE, jfExecDir);
return true;
}
return false;
Expand Down
4 changes: 3 additions & 1 deletion src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import * as core from '@actions/core';
import { exec, ExecOptions, ExecOutput, getExecOutput } from '@actions/exec';
import { HttpClient, HttpClientResponse } from '@actions/http-client';
import * as toolCache from '@actions/tool-cache';
import { chmodSync, existsSync, mkdirSync, promises as fs } from 'fs';
import { chmodSync, existsSync, promises as fs } from 'fs';
import { OutgoingHttpHeaders } from 'http';
import { arch, platform, tmpdir } from 'os';
import * as path from 'path';
Expand Down Expand Up @@ -265,6 +265,8 @@ export class Utils {
if (jfExecDir && jfrogExecDir) {
core.addPath(jfExecDir);
core.addPath(jfrogExecDir);
// Save the JF CLI path to use on cleanup. saveState/getState are methods to pass data between a step, and it's cleanup function.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's --> its

core.saveState(Utils.JF_CLI_PATH_STATE, jfExecDir);
return true;
}
return false;
Expand Down
Loading