Update: testing with vite and pnpm on stackblitz since npm not working #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asieduernest12
commented
Mar 19, 2024
| value = await newValue; | ||
| subscribers.forEach((callback) => callback(value)); | ||
| } | ||
|
|
||
| computeValue(); | ||
| if (["promise", "function"].includes(getInitialType())) computeValue(); |
There was a problem hiding this comment.
without this modifycation the code below breaks in testing
const basicAtom = atom(2)
expect(basicAtom.get()).toEqual(2)
so we can assume we only want to call computed if we are dealing with a promise or function. promise though?
asieduernest12
commented
Mar 19, 2024
| async function computeValue() { | ||
| const newValue = | ||
| typeof initialValue === "function" | ||
| ? (initialValue as AtomGetter<AtomType>)(get) | ||
| : value; | ||
| value = (null as AtomType); | ||
|
|
There was a problem hiding this comment.
auto format, can be ignored
asieduernest12
commented
Mar 19, 2024
| expect(cRes).includes(newB); | ||
| unsubB(); | ||
| }); | ||
|
|
There was a problem hiding this comment.
clearing the subscribtions in the for-loop since the idea is to validate a single atom change reflects on the computed atom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a basic test setup to explore how the implementation behaves.
Not sure about the awaits at the end, seem confusing but obviously care must be given when dealing with computed atom results