Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Maven Wrapper when the Windows user name contains spaces #28634

Merged

Conversation

ps10xgit
Copy link
Contributor

@ps10xgit ps10xgit commented Feb 8, 2025

fix could not perform Maven update when the Windows user name contains space.

This is based on a fix for maven-wrapper, see apache/maven-wrapper#152

Fix #28585

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

fix could not perform Maven update when the Windows user name contains space. This is based on a fix for maven-wrapper,
see apache/maven-wrapper#152

Fix jhipster#28585
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


objectsource seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mraible mraible closed this Feb 8, 2025
@mraible mraible reopened this Feb 8, 2025
@mraible mraible changed the title fix could not perform Maven update Fix Maven Srapper when the Windows user name contains spaces Feb 8, 2025
@mraible mraible changed the title Fix Maven Srapper when the Windows user name contains spaces Fix Maven Wrapper when the Windows user name contains spaces Feb 8, 2025
@mraible mraible enabled auto-merge (squash) February 8, 2025 17:33
@mraible mraible merged commit 22b44b3 into jhipster:main Feb 8, 2025
137 of 146 checks passed
@mraible mraible added this to the 8.9.0 milestone Feb 8, 2025
@mraible
Copy link
Contributor

mraible commented Feb 8, 2025

@ps10xgit Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not Perform Maven Update
3 participants