-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it compatible with latest version of Flutter Sdk and JAVA version #1368
base: master
Are you sure you want to change the base?
Conversation
[REMOVED] removed invalid lint `invalid_dependency`
[UPDATED] updated java and kotlin version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed and tested all the changes.
when it will merged to main? |
@inamhusain Waiting for repo owner to accept pull request. |
@jhomlala any news on this? |
Hello @pintusingh28 . Thanks for raising this PR. Unfortunately the developer of better player hasn't been getting enough time to work and maintain this project. So have forked and maintaining this project as awesome_video_player here (https://pub.dev/packages/awesome_video_player) Would be wonderful if you can raise this PR there 🎊 🥳 |
@nateshmbhat You GitHub repo seems private, you need to keep it public, So I can create PR |
Oops that was by mistake. Have fixed it now 🙏🏻 Thank You |
I have made the library to compatible with latest versions of Android Studio and Flutter sdk:
Changelog:
hashValues
withObject.hash
method