Style update #11
Merged
Style update #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new ViewModifiers, ButtonStyles, and Buttons to keep the styling of buttons consistent throughout the UI
- if there is only 1 heart rate data point, the graph is not interesting and can have strange problems, so it is only available if there are multiple data points - if a segment of the HR graph only has 1 datum, the scaling would return `nan` for the width, causing a purple runtime warning in XCode for invalid frame dimensions; solution to have width of rectangle be 1 if only 1 data point is available
- Done button style with stronger rounding of corners (pill shape) - in EditExerciseView, reduce Save opacity when disabled - Color extension to take HEX - Color extension with different shadings of workoutRed - WelcomeView invert button color (colored background, white text)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the style of buttons, the spinner, the spinner pointer, the starting WelcomeView.