Explicitly set Column.accessor when binding a column to allow `order()` method to use its value #979

jieter · 2024-12-20T16:00:30Z

This allows using the accessor to be used as part of an expression, for example when using a custom column with an order() method:

class UserNameColumn(tables.Column):
    def order(self, queryset, is_descending):
        order_field = Lower(self.accessor)
        if is_descending:
            order_field = order_field.desc()
        return queryset.order_by(order_field), True

…y to use its value

jieter · 2024-12-20T16:02:26Z

tests/test_core.py


        table = SimpleTable(MEMORY_DATA)
+        self.assertEqual(table.columns["col1"].accessor, "alpha__upper__isupper")
+        self.assertEqual(table.columns["col2"].accessor, "alpha__upper")
+        self.assertEqual(table.columns["beta"].accessor, "beta")


before this change, the accessor would equal None

Explicitly set Column.accessor when binding a column to allow order_b…

de2ef09

…y to use its value

jieter commented Dec 20, 2024

View reviewed changes

jieter merged commit df4fea9 into master Dec 21, 2024
28 checks passed

jieter deleted the feature/explicit-accessor branch December 21, 2024 09:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Explicitly set Column.accessor when binding a column to allow `order()` method to use its value #979

Explicitly set Column.accessor when binding a column to allow `order()` method to use its value #979

jieter commented Dec 20, 2024

jieter Dec 20, 2024

Explicitly set Column.accessor when binding a column to allow order() method to use its value #979

Explicitly set Column.accessor when binding a column to allow order() method to use its value #979

Conversation

jieter commented Dec 20, 2024

jieter Dec 20, 2024

Choose a reason for hiding this comment

Explicitly set Column.accessor when binding a column to allow `order()` method to use its value #979

Explicitly set Column.accessor when binding a column to allow `order()` method to use its value #979