Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lee Ho Seong #10

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Lee Ho Seong #10

wants to merge 21 commits into from

Commits on Dec 19, 2023

  1. Initial commit

    @jihwooon @leon-808
    jihwooon authored and leon-808 committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    d9bee02 View commit details
    Browse the repository at this point in the history

  2. update, draw 함수 리팩터링 

    메소드 추출을 통해 한 메소드가 한가지 일만 하도록 크기를 줄였음
추상화 수준을 맞춤으로써 가독성 향상
    @leon-808
    leon-808 committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    bd6746e View commit details
    Browse the repository at this point in the history

  3. ch01 예제 세가지 풀이와 eslint 따옴표 해결 

    ch01 sum 예제는 풀이하지 않음
    @leon-808
    leon-808 committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    f964ca5 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. sum.test.ts 풀이 

    describe, context, it, expect, tobe 구조 적용
    @leon-808
    leon-808 committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    d6e7cb1 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Input 인터페이스, 클래스로의 코드 이관 

    간단한 if 문의 리팩토링을 수행
    @leon-808
    leon-808 committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    87b1262 View commit details
    Browse the repository at this point in the history

  2. 신호등 기능 interface, class 로의 코드 이관 및 테스트 

    테스트를 위하여 원래 void 였던 updateCar() 함수를 임시로 boolean 으로 변경
    @leon-808
    leon-808 committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    f268a65 View commit details
    Browse the repository at this point in the history

  3. 타일 Interface, Class 로의 코드 이관 및 에러 

    if 문 리팩토링시 map[y][x] 에서 메서드 인식 불가
map 생성 함수를 고쳐서 map[y][x] 가 클래스로 받아들여지도록 해야할듯 싶음
    @leon-808
    leon-808 committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    78ab05a View commit details
    Browse the repository at this point in the history

  4. Map 변수, 생성 함수로 에러 해결 및 PR 제언 토대로 수정 

    remove 함수 수정 전까지의 작업 완료
    @leon-808
    leon-808 committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    21c83cb View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. Remove 메서드 전문화, colorOfTile 클래스로 코드 이관 

    -
    @leon-808
    leon-808 committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    207897b View commit details
    Browse the repository at this point in the history

  2. if 문 추가 이관을 통해 color 를 draw 함수로 변경 

    -
    @leon-808
    leon-808 committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    ab5ae4c View commit details
    Browse the repository at this point in the history

  3. moveHorizontal, Vertical 인라인화 

    클래스로의 코드 이관을 통한 if 문, 함수 리팩터링
    @leon-808
    leon-808 committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    f223e7b View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2023

  1. stony, boxy 메서드 추가 및 stone, box 클래스 리팩터링 

    생성자와 추가 인터페이스 도입으로 if문 간소화
    @leon-808
    leon-808 committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    6733d98 View commit details
    Browse the repository at this point in the history

  2. .prettierignore 파일 무시 

    개인적으로 사용하는 prettier 를
이 프로젝트에서 작동하지 않게 하는 파일입니다.
    @leon-808
    leon-808 committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    a8e4e99 View commit details
    Browse the repository at this point in the history

  3. 조건문에서 부수적인 동작 분리 

    -
    @leon-808
    leon-808 committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    44826c2 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2023

  1. updateTile 인라인화와 불필요한 코드 정리 

    -
    @leon-808
    leon-808 committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    755dc54 View commit details
    Browse the repository at this point in the history

  2. FallStrategy 클래스로 코드 이관 및 메소드 통합 

    -
    @leon-808
    leon-808 committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    5a9d2f1 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. Array.ts 전략 패턴 적용 

    MinimumProcessor, SumProcessor 클래스 분리하여 컴포지션
    @leon-808
    leon-808 committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    6068dff View commit details
    Browse the repository at this point in the history

  2. Processor 인터페이스를 생성해 유사한 클래스 통합 

    -
    @leon-808
    leon-808 committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    20ecf29 View commit details
    Browse the repository at this point in the history

  3. remove 함수를 하나로 통합하기 위한 인터페이스 도입 

    -
    @leon-808
    leon-808 committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    f50acda View commit details
    Browse the repository at this point in the history

  4. Key 와 Lock 클래스의 통합 

    ts 내부에 동일 클래스명이 있어서 Locker 로 변경
    @leon-808
    leon-808 committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    0983348 View commit details
    Browse the repository at this point in the history

  5. 전략 패턴 적용을 위한 KeyConfiguration 클래스 도입 

    -
    @leon-808
    leon-808 committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    7474c00 View commit details
    Browse the repository at this point in the history