Feature added: Ability to force email and name entry

[bkruger99]

Only available via lambda at the moment as I'm not sure how to parse .env file for the front end ui to do the right thing.

[jimpick]

This looks great!

When I get some free time (this weekend hopefully), I'll try it out and merge it in if all goes well.

[bkruger99]

Thanks. If you have an idea how to inject into the UI to read the env variables (js is not my strong suit), then I can implement before submission on the UI side. Tests maybe broken, didn't update those, will try to get a look at it, but don't wait for me. :)

[jimpick]

I think we'll need to update this file to include the env variable and
compile it into the bundle that webpack generates:

https://github.com/jimpick/lambda-comments/blob/master/packages/frontend/webpack.config.js#L69

I haven't looked at your code yet - I'll check it out soon.

On Wed, Jul 27, 2016 at 5:31 PM, Brian Kruger [email protected]
wrote:

Thanks. If you have an idea how to inject into the UI to read the env
variables (js is not my strong suit), then I can implement before
submission on the UI side. Tests maybe broken, didn't update those, will
try to get a look at it, but don't wait for me. :)

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#14 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABRlsfB-tCFHMS0Dtq4EkirqSjEsihrks5qZ_hdgaJpZM4JWqUz
.

[bkruger99]

If the .env can be pulled into the FE UI, then adding your other open issue of content length should be fairly trivial. Whenever you get around to the code check, no hurry.

[bkruger99]

Looking at this a little more, yeah. I get how to potentially pass some things into the UI. Probably would be useful to make a util/config.js perhaps to pass some items in. Not sure if there's a way to stringify everything from it in case of major expansion, but I have an idea. I'll play around and try to amend the pull request to cover front end ui, probably be a few days before I get to it.

[bkruger99]

Finally got around to finishing this as it was bugging me.

Front end validation done (not in the tests)
Implemented #1 and #8 fixes as well both front and back end.
(#8 is a simple regex)

Added bonus: character counter above the text box.

[bkruger99]

@jimpick you still alive there? :)

[jimpick]

Sorry, been super busy. I'm way overdue to put some time in on this project.