Add function to look up arbitrary resource names in discovery cache #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To implement #212, we need the ability to convert from the kind name, e.g. `Pod`, to the plural form, e.g. `pods`. This would be analogous to the existing `kele--get-singular-for-plural`, e.g. `kele--get-plural-for-kind`. Since we'd rather not implement one function for each 2-permutation of singular/plural/kind, we generalize the existing `get-singular-for-plural` to allow for looking up a "discovery resource" by any given key within it. This will allow us to look up with, say, `singularName`, and use the retval to get the `kind`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
==========================================
+ Coverage 62.86% 62.90% +0.04%
==========================================
Files 1 1
Lines 762 763 +1
==========================================
+ Hits 479 480 +1
Misses 283 283 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To implement #212, we need the ability to convert from the kind name, e.g.
Pod, to the plural form, e.g.pods. This would be analogous to the existingkele--get-singular-for-plural, e.g.kele--get-plural-for-kind.Since we'd rather not implement one function for each 2-permutation of singular/plural/kind, we generalize the existing
get-singular-for-pluralto allow for looking up a "discovery resource" by any given key within it. This will allow us to look up with, say,singularName, and use the retval to get thekind.