feat(android): use fresco 3.2.0 in order to fix animation for gifs #15583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
reviewed
Feb 7, 2025
| @@ -69,10 +69,29 @@ allprojects { | |||
| } | |||
| } | |||
|
|
|||
| // Due to a dependency conflict between React Native and the Fresco library used by GiphySDK, | |||
| // GIFs appear as static images instead of animating | |||
| // https://github.com/Giphy/giphy-react-native-sdk/commit/7fe466ed6fddfaec95f9cbc959d33bd75ad8f900 | |||
There was a problem hiding this comment.
Isn't that the solution for RN 0.76? For below it says:
Developers using our SDK with React Native versions from 0.73 up to but not including 0.76 can resolve this conflict
by adding the following block to the android/build.gradle file in the :app module,
right before the dependencies section:
configurations.all {
resolutionStrategy {
forcedModules = ['com.giphy.sdk:ui:2.3.13']
}
}There was a problem hiding this comment.
I know, but no. That doesn't work. I think maybe they are mistaken, at least starting with rn 0.75.4 that doesn't work.
saghul
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.