Fix deprecated check routines in ASTNode to also check since value

- fixes eclipse-jdt#2873

org.eclipse.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/ast/ASTNode.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2000, 2023 IBM Corporation and others.
+ * Copyright (c) 2000, 2024 IBM Corporation and others.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -59,11 +59,13 @@
 import org.eclipse.jdt.internal.compiler.ast.TypeReference.AnnotationPosition;
 import org.eclipse.jdt.internal.compiler.classfmt.ClassFileConstants;
 import org.eclipse.jdt.internal.compiler.env.AccessRestriction;
+import org.eclipse.jdt.internal.compiler.impl.StringConstant;
 import org.eclipse.jdt.internal.compiler.lookup.AnnotationBinding;
 import org.eclipse.jdt.internal.compiler.lookup.ArrayBinding;
 import org.eclipse.jdt.internal.compiler.lookup.Binding;
 import org.eclipse.jdt.internal.compiler.lookup.BlockScope;
 import org.eclipse.jdt.internal.compiler.lookup.ClassScope;
+import org.eclipse.jdt.internal.compiler.lookup.ElementValuePair;
 import org.eclipse.jdt.internal.compiler.lookup.ExtraCompilerModifiers;
 import org.eclipse.jdt.internal.compiler.lookup.FieldBinding;
 import org.eclipse.jdt.internal.compiler.lookup.InferenceContext18;
@@ -528,6 +530,8 @@ public final boolean isFieldUseDeprecated(FieldBinding field, Scope scope, int f
 		// inside same unit - no report
 		if (scope.isDefinedInSameUnit(field.declaringClass)) return false;
 
+		if (sinceValueUnreached(field, scope)) return false;
+
 		// if context is deprecated, may avoid reporting
 		if (!scope.compilerOptions().reportDeprecationInsideDeprecatedCode && scope.isInsideDeprecatedCode()) return false;
 		return true;
@@ -578,6 +582,8 @@ public final boolean isMethodUseDeprecated(MethodBinding method, Scope scope,
 		// inside same unit - no report
 		if (scope.isDefinedInSameUnit(method.declaringClass)) return false;
 
+		if (sinceValueUnreached(method, scope)) return false;
+
 		// non explicit use and non explicitly deprecated - no report
 		if (!isExplicitUse &&
 				(method.modifiers & ClassFileConstants.AccDeprecated) == 0) {
@@ -589,6 +595,35 @@ public final boolean isMethodUseDeprecated(MethodBinding method, Scope scope,
 		return true;
 	}
 
+	private boolean sinceValueUnreached(Binding binding, Scope scope) {
+		AnnotationBinding[] annotations= binding.getAnnotations();
+		for (AnnotationBinding annotation : annotations) {
+			if (String.valueOf(annotation.getAnnotationType().readableName()).equals("java.lang.Deprecated")) { //$NON-NLS-1$
+				ElementValuePair[] pairs= annotation.getElementValuePairs();
+				for (ElementValuePair pair : pairs) {
+					if (String.valueOf(pair.getName()).equals("since")) { //$NON-NLS-1$
+						if (pair.getValue() instanceof StringConstant strConstant) {
+							try {
+								String value= strConstant.stringValue();
+								int sinceValue= Integer.parseInt(value);
+								// As long as the AST levels and ClassFileConstants.MAJOR_VERSION grow simultaneously,
+								// we can use the offset of +44 to compute the Major version from the given AST Level
+								long sinceLevel= ClassFileConstants.getComplianceLevelForJavaVersion(sinceValue + 44);
+								long sourceLevel= scope.compilerOptions().sourceLevel;
+								if (sourceLevel < sinceLevel) {
+									return true;
+								}
+							} catch (NumberFormatException e) {
+								// do nothing and fall through
+							}
+						}
+					}
+				}
+			}
+		}
+		return false;
+	}
+
 	public boolean isSuper() {
 
 		return false;
@@ -649,6 +684,8 @@ public final boolean isTypeUseDeprecated(TypeBinding type, Scope scope) {
 		// inside same unit - no report
 		if (scope.isDefinedInSameUnit(refType)) return false;
 
+		if (sinceValueUnreached(refType, scope)) return false;
+
 		// if context is deprecated, may avoid reporting
 		if (!scope.compilerOptions().reportDeprecationInsideDeprecatedCode && scope.isInsideDeprecatedCode()) return false;
 		return true;