Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use yannh/kubernetes-json-schema #76

Merged
merged 2 commits into from
Apr 2, 2021
Merged

Use yannh/kubernetes-json-schema #76

merged 2 commits into from
Apr 2, 2021

Conversation

adnaan
Copy link
Contributor

@adnaan adnaan commented Mar 28, 2021 •
edited
Loading

Use yannh/kubernetes-json-schema instead of jkcfg/kubernetes-schema

Why ?

yannh/kubernetes-json-schema seems to be a regularly synced fork. See issue: instrumenta/kubernetes-json-schema#26

Changes

  1. Updated Makefile to use a sparse checkout of v*-local directories.
  2. Removed SCHEMA_ZIP
  3. Use master of yannh/kubernetes-json-schema

@adnaan adnaan marked this pull request as draft March 28, 2021 10:27
@adnaan adnaan requested a review from squaremo March 28, 2021 13:43
@adnaan adnaan marked this pull request as ready for review March 28, 2021 13:43
@adnaan adnaan requested a review from dlespiau March 28, 2021 14:01
squaremo
squaremo reviewed Mar 30, 2021
View reviewed changes
Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 for switching repos and not having to maintain our own fork.
I tried this locally and it does what it says :-)

I've commented below on using master as the target. Let's have that discussion then I'll give this a green stamp.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
adnaan
adnaan commented Mar 30, 2021
View reviewed changes
Makefile Show resolved Hide resolved
squaremo
squaremo approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice git-fu, thanks @adnaan 🍏

@adnaan
Copy link
Contributor Author

adnaan commented Apr 2, 2021

Thank you for the assist @squaremo :)

@adnaan adnaan merged commit dc2ffff into master Apr 2, 2021
@adnaan adnaan deleted the update_kubernetes_json_schema branch April 2, 2021 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squaremo squaremo squaremo approved these changes

@dlespiau dlespiau Awaiting requested review from dlespiau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adnaan @squaremo