some little improvements #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. fix a problem on ACWebDAVItem's createDateStr and modifyDateStr, it will not return nil now(reference from DAVKit) 2.fix a bug on transfering the parameter overwrite on ACWebDAVCopyRequest; It didn't transfer overwrite successfully before. 3. fix the delegate call of ACWebDAVCopyRequest and ACWebDAVMoveRequest
1.ACWebDAVDownloadRequest.h&.m
add a new var to hold the reference of currentConnection, used to
cancel a request if needed;
also add a new method(cancel) to cancel this request
2.ACWebDAVDeleteRequest.m
- connection: didReceiveResponse: response.statusCode=201
OR response.statusCode=204 all shows deleted successfully.
3.ACWebDAVClient.h - add new optional delegate methods
- (BOOL)needToCancelDownload;
- (void)resetCancelDownload:(BOOL)cancel;
- (BOOL)needToCancelUpload;
- (void)resetCancelUpload:(BOOL)cancel;
used to check if need to cancel a request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.fix a problem on ACWebDAVItem's createDateStr and modifyDateStr,
it will not return nil now(reference from DAVKit)
2.fix a bug on transfering the parameter overwrite in ACWebDAVCopyRequest;
It didn't transfer overwrite successfully before.
3 fix the delegate call of ACWebDAVCopyRequest and ACWebDAVMoveRequest;
4.ACWebDAVDownloadRequest.h&.m
request if needed;
cancelto cancel this request5.ACWebDAVDeleteRequest.m
- connection: didReceiveResponse:6.ACWebDAVClient.h
- (BOOL)needToCancelDownload- (void)resetCancelDownload:(BOOL)cancel- (BOOL)needToCancelUpload- (void)resetCancelUpload:(BOOL)cancelused to check if need to cancel a request