Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix middleSplit_ for same points #250

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

yzabalotski
Copy link

While #220 decreases amount of middleSplit_ calls, it also prevents finding correct min_elem and max_elem when max_span == 0 and span == 0. What leads to wrong cutval calculation and out of range reads at divideTree.

The issue can be observed with the unit test executed under valgrind.

@jlblancoc jlblancoc merged commit 0e740cd into jlblancoc:master Nov 4, 2024
6 checks passed
@jlblancoc
Copy link
Owner

Good catch, thanks! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants