Added a 10 second HTTPClient connection timeout #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meout to the HTTP Client connection so that it doesn't stall builds in the event of a network issue.
|
@jlewallen ping - could this be merged downstream and released? hipchat of late has had stability problems and we have had totally wedged builds due to this plugin. I also note that there seem to be 3 locations issues are reported: here, the jenkinsci fork and even Jira - which one is official? |
|
@warmfusion Could you move this PR to https://github.com/jenkinsci/hipchat-plugin. |
| /** | ||
| * HTTP Connection timeout when making calls to HipChat | ||
| */ | ||
| public static final Integer CONNECTION_TIMEOUT = 10000; |
There was a problem hiding this comment.
Could you rename it to DEFAULT_TIMEOUT instead? The reasoning being that the same value is being used for both connection and read timeout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#62 - Added a 10 second hardcoded connection and transfer timeout to the HTTP Client connection so that it doesn't stall builds in the event of a network issue.