Update client developer guide #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilj
requested changes
Jun 5, 2020
nowylie
force-pushed
the
update-client-guide
branch
from
92eee77 to
185d6a0
Compare
|
Suggested changes incorporated! |
neilj
requested changes
Jun 5, 2020
client-guide/jmap-client-guide.mdown
Outdated
| "mailbox1": true | ||
| }, | ||
| "keywords": { | ||
| "$seen": false, |
There was a problem hiding this comment.
There should be nothing mapping to false. It either maps to true or it's omitted. I think let's just have $seen mapping to true.
client-guide/jmap-client-guide.mdown
Outdated
| "$seen": false, | ||
| "$flagged": false, | ||
| "$answered": false, | ||
| "$draft": false |
There was a problem hiding this comment.
For this one the scenario is that two new emails were received, so I think it should be keywords: {}
client-guide/jmap-client-guide.mdown
Outdated
| "$seen": false, | ||
| "$flagged": false, | ||
| "$answered": false, | ||
| "$draft": false |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #307
Partially addresses #323