Change path detection for liquidctl.exe #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path should now always resolve to the same as the one where the FanControl.Liquidctl.dll is
…("Fan 1 speed", "Fan 2 speed", etc)
- I probably violated a dozen of best practices though
- Fixed a bug where status values that are not numbers/floats prevented the plugin from working
- Replaced the hardcoded location of the liquidctl.exe to match the directory where the FanControl.Liquidctl.dll is located. So you can now also install the plugin over the Fan Control interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path for
liquidctl.exeshould now always resolve to the same as the one where theFanControl.Liquidctl.dllis.So you can either place the files directly within the
Plugins\directory, or install it over the FanControl interface (which puts them intoPlugins\Liquidctl\.