Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruleset to match FsharpLint #64

Open
2 of 3 tasks
milbrandt opened this issue Jun 20, 2019 · 0 comments
Open
2 of 3 tasks

Update ruleset to match FsharpLint #64

milbrandt opened this issue Jun 20, 2019 · 0 comments

Comments

@milbrandt
Copy link
Collaborator

milbrandt commented Jun 20, 2019

Open questions from PR #61

  • In org.sonar.plugins.fsharp.FSharpSonarRulesDefinition there are 16 additional rules which are not activated in FSharpSonarWayProfile. Some of them should IMHO included, eg RulesRedundantNewKeyword Why are These rules not included? Any history behind it? These rules are unchanged for now.
    Comment from Jorge: The asnwer is pretty much the same, the rules have not ever been stabilized and i supose after of both sonar and fsharp lint those have just become outdated. My sughestion is we take what fsharp lint provides now and go with it.
  • Missing HtmlDesicription of the rules are in sonar-fsharp-plugin\src\main\resources\org\sonar\l10n\fsharp\rules?
    Comment from Jorge: Hrmldescriptiosn i have no idea what to put there, i would rather just not have everything
  • why set priority in org.sonar.plugins.fsharp.FSharpSonarWayProfile.activateRule as it is already set in FSharpSonarRulesDefinition while creating the rules?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant