Update to net472 and net.sdk

[milbrandt]

• Updated Project files to new Project Format style
• Updated from .NET Framework 4.5 to 4.7.2 (not going to dotnet Core as FSharp Compiler.Service.* is not available therefore)
• added NUnit TestAdapter for Visual Studio 2017 as Nuget package
• updated most Nuget packages (all except for FSharp Compiler.Service.* and FSharpLint.Core)

Open points:

• several links are broken in sonar-fsharp-plugin\src\main\resources\org\sonar\l10n\fsharp\rules\fsharplint Issue Broken links in locatization #49
• junit tests results are not reported in AppVeyor (only 21 F# Tests, 1 Junit test is missing) Issue Upload JUnit test results in CI build #50
• [fs-]analysis-(input|output).xml - which ones are needed, all required available? Issue Check which *analysis*.xml files are required #51
• pom files parent references fixed in PR Information in SonarQube-Administration-Marketplace #48
• Adjustments required to handle new rules ofFSharpLint (F# solution, Java wrapper plugin) Issue Update ruleset to match FsharpLint #64

Test:

• @jmecosta
• @milbrandt - Sonarqube 7.7 developer Edition, Windows 7

Reminder: DO SQUASH MERGE

[jmecosta]

@jmecosta Unfortunately not yet :( There is still an issue with the plugin build in the pom. ANd then we have to test - it is update with lots of breaking changes in the dependencies.

But on the bright side: the number of rules have increased in FsharpLint and I could create some additional PRs on other projects

ok no problem, ive reference this TrimbleSolutionsCorporation/VSSonarQubeExtension#278 to upgrade the linter there to last version and i will do all the testing then in our internal servers also!

[milbrandt]

@jmecosta and everyone else: Any comments and help on open points are welcome. Especially on the two last ones, which are not so obvious.

[milbrandt]

Looks like there is no more run in pom.xml to build the solution

? so how do I build the all thing locally without manually building the core first

Now with the updated pom files you can build locally everything with Maven again, with configuration Debug or Release:

mvn -Dconfiguration=Debug clean package

[milbrandt]

@jmecosta Build 193-rc I installed on our server in production. If you could verify on your side that no crash occurs and some reports are published on Sonarqube Server I would like to squash merge this PR. On the next days I'll observe our server regarding F# builds.

[jmecosta]

compilation now works fine thanks, im installed the plugin in server and run analysis all working perfectly fine. Thanks

[jmecosta]

good to be merged