Lock Improvements #131
Merged
Lock Improvements #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having the lock be an argument makes it easier to implement different types of locks, since we won't need to subclass from Scheduler and instead can implement smaller classes.
This allows for multiple scheduling processes to run concurrently, but only one of them will run jobs at any given time.
This was referenced Aug 14, 2014
Closed
|
I like it. I'll look at it in detail when I get back from work. |
|
@jmettraux ping. Anything I need to do to get this in? |
|
@ecin please be patient. I'm giving it two hours of my saturday morning. |
|
Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a better attempt at a refactor that allows for a high availability scheduling setup.
@scheduler_lock, which determines if a scheduler should come up, vs. a@job_lock, which determines if a triggered job should run:scheduler_lockand:job_lockoptions so that no subclassing is needed to determine how your scheduler figures out its locking situation:lockfileoption is still supportedTests are provided for both locking scenarios.
This PR extends on #129, 'cause apparently Github doesn't update closed pull requests.