Merge pull request #214 from olibye/master

Revert junit upgrade for legacy (Junit 3) tests
jmock-developers · Apr 2, 2021 · 307f6c2 · 307f6c2
2 parents fa32c0a + bca145a
commit 307f6c2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/jmock-junit3/pom.xml b/jmock-junit3/pom.xml
@@ -22,7 +22,7 @@
             <groupId>junit</groupId>
             <artifactId>junit</artifactId>
             <!-- Because thats what we're regressing against -->
-            <version>4.13</version>
+            <version>3.8.2</version>
             <scope>compile</scope>
         </dependency>
 

diff --git a/jmock-junit4/src/test/java/org/jmock/test/acceptance/junit4/JUnit4TestRunnerTests.java b/jmock-junit4/src/test/java/org/jmock/test/acceptance/junit4/JUnit4TestRunnerTests.java
@@ -47,8 +47,9 @@ public void testTheJUnit4TestRunnerReportsIfMoreThanOneMockeryIsFound() {
     public void testDetectsNonPublicBeforeMethodsCorrectly() {
         listener.runTestIn(JUnit4TestWithNonPublicBeforeMethod.class);
         listener.assertTestFailedWith(Throwable.class);
-        assertTrue("should have detected non-public before method",
-                listener.failure.getMessage().contains("Method before() should be public"));
+        assertEquals("should have detected non-public before method",
+                "Method before() should be public",
+                       listener.failure.getMessage());
     }
 
     public void testAutoInstantiatesMocks() {

diff --git a/pom.xml b/pom.xml
@@ -47,7 +47,7 @@
 
         <downloadSources>true</downloadSources>
         <hamcrest.version>2.2</hamcrest.version>
-        <junit.version>4.13</junit.version>
+        <junit.version>4.12</junit.version>
         <asm.version>8.0.1</asm.version>
         <objenesis.version>3.1</objenesis.version>
         <bsh.version>2.0b6</bsh.version>