Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid operations on uninitialised memory in HMMs #1121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MBradbury
Copy link

Fix for #1078 by using torch.full to initalise tensors full of -inf instead of using torch.empty and then subtracting inf. Otherwise there is the potential for these tensors to contain NaNs if the uninitalised memory contains values such as inf or -inf.

The tensors initalised with torch.zeros are correct, but have been changed to match the other tensor initialisation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant