-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributing Guidelines #516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also mention the need to register TypeAdapters (and how to do that) when adding new hive types
Fixed in 0aef744 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall!
README.md
Outdated
Finamp uses Weblate to manage translations: **https://hosted.weblate.org/engage/finamp/** | ||
|
||
Feel free to add new languages if yours isn't there yet. If you have any questions, such as the context of a string, you can ask in the [Translation Discussions](https://github.com/jmshrv/finamp/discussions/categories/translations). | ||
Finamp's contributing guidelines can be found in [CONTRIBUTING.md](CONTRIBUTING.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe something a bit more motivational would be nice.
Finamp is a community-driven project and relies on people like you and their contributions. To learn how you could help out with making Finamp even better, take a look at our Contribution Guidelines
I went ahead and merged it. It's definitely better than nothing, and right now everything looks good to me 😁 |
This PR adds some basic contributing guidelines, mostly related to setting up a development environment. It covers most of the weird bits of working on Finamp, I can't think of anything more to say.
(pubspec.lock was also updated lol)