Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing Guidelines #516

Merged
merged 12 commits into from
Dec 5, 2023
Merged

Contributing Guidelines #516

merged 12 commits into from
Dec 5, 2023

Conversation

jmshrv
Copy link
Owner

@jmshrv jmshrv commented Oct 21, 2023

This PR adds some basic contributing guidelines, mostly related to setting up a development environment. It covers most of the weird bits of working on Finamp, I can't think of anything more to say.

(pubspec.lock was also updated lol)

@jmshrv jmshrv requested a review from Chaphasilor October 21, 2023 17:56
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
pubspec.lock Outdated Show resolved Hide resolved
Copy link
Collaborator

@Chaphasilor Chaphasilor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also mention the need to register TypeAdapters (and how to do that) when adding new hive types

@jmshrv
Copy link
Owner Author

jmshrv commented Nov 30, 2023

Also mention the need to register TypeAdapters (and how to do that) when adding new hive types

Fixed in 0aef744

@jmshrv jmshrv requested a review from Chaphasilor November 30, 2023 15:02
Copy link
Collaborator

@Chaphasilor Chaphasilor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall!

README.md Outdated
Finamp uses Weblate to manage translations: **https://hosted.weblate.org/engage/finamp/**

Feel free to add new languages if yours isn't there yet. If you have any questions, such as the context of a string, you can ask in the [Translation Discussions](https://github.com/jmshrv/finamp/discussions/categories/translations).
Finamp's contributing guidelines can be found in [CONTRIBUTING.md](CONTRIBUTING.md)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something a bit more motivational would be nice.

Finamp is a community-driven project and relies on people like you and their contributions. To learn how you could help out with making Finamp even better, take a look at our Contribution Guidelines

@Chaphasilor Chaphasilor merged commit 4e1f166 into main Dec 5, 2023
4 checks passed
@Chaphasilor
Copy link
Collaborator

I went ahead and merged it. It's definitely better than nothing, and right now everything looks good to me 😁

@jmshrv jmshrv deleted the contributing branch March 11, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants