-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👀 Rework Material 3 theme #561
Conversation
bb96e83
to
02f1116
Compare
Please give it a test, had to resolve some other issues as well and hope I caught everything. |
@@ -283,9 +283,6 @@ class Finamp extends StatelessWidget { | |||
|
|||
@override | |||
Widget build(BuildContext context) { | |||
const Color accentColor = Color(0xFF00A4DC); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to keep the original accent color here for reference :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added it back in lib/color_schemes.g.dart
with a comment.
Aside from that everything looks nice, definitely much better than the "default" / whatever crap that was there before 😅 |
Fixed the tab bar issue as well, it's actually pretty easy:
So, just set
Nvm, fixed that too. |
Merge active and buffered tracks into a single slider, properly handle slider height.
Fixed your remaining points that I completely missed last night, as well as some other things. |
Thanks for this! Merged :) |
Sure, happy to contribute! I might actually further tweak some colors later, but for now, this should be good. |
After some dependency bump the new Material 3 style is enabled by default, which looks kind of odd with the current color schemes.
Old design
Thus, I generated a nice one with the M3 Theme Builder and imported it into the project.
New design