Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throwaway #20

Closed
wants to merge 107 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
107 commits
Select commit Hold shift + click to select a range
79d2389
Ability to disregard duplicate runfolders.
mgcam Sep 20, 2023
71abfbb
Simplified samplesheet auto-generation code.
mgcam Sep 22, 2023
ad099bf
Merge pull request #756 from mgcam/proceed_with_folder_duplicates
kjsanger Sep 22, 2023
3585391
Merge pull request #757 from mgcam/simplify_samplesheet_auto
jmtcsngr Sep 22, 2023
d0ed22d
Drop xml fixtures in tests for samplesheet generation (#753)
mgcam Sep 26, 2023
452b87d
Use correct name instrument name pattern in docs.
mgcam Sep 29, 2023
ba5937d
Merge pull request #759 from mgcam/update_doc
dkj Oct 4, 2023
a82cf95
Deleted the xml driver for st::api::lims. (#758)
mgcam Oct 5, 2023
8186e2b
Capture current behaviour of the genome_reference method (#760)
mgcam Oct 10, 2023
10bcd8f
Deleted low-level LIMS XML API
mgcam Oct 12, 2023
e6505a4
Deleted low value live tests
mgcam Oct 12, 2023
eeb13a1
Removed LIMS XML test fixtures
mgcam Oct 12, 2023
b0f39c1
Merge pull request #762 from mgcam/drop_lims_xml_api
zb32 Oct 23, 2023
4899f25
Merge pull request #763 from mgcam/remove_lims_xml_fixtures
zb32 Oct 23, 2023
54a46ad
Updated DBIx classes from the prod database.
mgcam Oct 23, 2023
fa60e2b
Removed deprecated seq_qc_state method from st::api::lims
mgcam Oct 24, 2023
9b240ab
Removed deprecated methods for retrieving lims object descendants
mgcam Oct 24, 2023
9e2b474
Merge pull request #766 from mgcam/dbix_clases_update
nerdstrike Oct 24, 2023
7fa3eb0
Merge pull request #767 from mgcam/drop_deprecated
nerdstrike Oct 24, 2023
2f26297
Dropped unused constants
mgcam Oct 24, 2023
0ce39cb
Merge pull request #768 from mgcam/drop_unused_constants
nerdstrike Oct 24, 2023
723868a
Dropped lims accessors for which no data exist.
mgcam Oct 25, 2023
7b8e6fc
Merge pull request #769 from mgcam/drop_unused_attributes
nerdstrike Oct 26, 2023
8e9048e
Restricted automatically meargeable to NovaSeq.
mgcam Oct 26, 2023
b3525ab
Fixed typos
mgcam Oct 26, 2023
928d753
Merge pull request #770 from mgcam/simplify_all_lanes_mergeable
mgcam Oct 27, 2023
385d7a5
Deleted the code for inline indexes.
mgcam Oct 19, 2023
fd3a5fe
Dropped derived library type and barcode sequence.
mgcam Oct 19, 2023
a246c44
Move docs about plural methods closer to the code
mgcam Oct 27, 2023
6f077e7
Limit DRAGEN analysis to human samples only.
mgcam Oct 30, 2023
322a40a
Merge pull request #765 from mgcam/lims_drop_inline_index
dozy Oct 30, 2023
8c37ec4
Removed fallback to study ref genome for complex tag zero and lane-le…
mgcam Oct 30, 2023
ad5bbf0
Record all recent changes
mgcam Oct 31, 2023
1035236
Fixed typos and deleted superfluous commas
mgcam Oct 31, 2023
895b02e
Merge pull request #773 from mgcam/log_changes
jmtcsngr Oct 31, 2023
020fd59
Merge remote-tracking branch 'upstream/master' into devel
jmtcsngr Nov 1, 2023
a1a0801
Merge pull request #775 from jmtcsngr/devel
jmtcsngr Nov 1, 2023
177b549
Merge pull request #771 from mgcam/only_human_ref
kjsanger Nov 6, 2023
c9a37bd
Added a method for aggregation by library
mgcam Oct 27, 2023
00ba90e
Moved some tests to a new test script.
mgcam Nov 14, 2023
0127b18
Added tests for merging by library.
mgcam Nov 14, 2023
7a25f37
Distinguish between NovaSeq and NovaSeqX RunParams.
mgcam Nov 17, 2023
1bdc279
More robust evaluation.
mgcam Nov 17, 2023
bb26c0d
Merge pull request #777 from mgcam/nova_seq_discovery
dkj Nov 17, 2023
b6bfc15
Added a NovaSeqX samplesheet
mgcam Nov 22, 2023
6d500bf
Ensure insert size is returned for compositions.
mgcam Nov 22, 2023
a740443
Merge pull request #778 from mgcam/isize4multiple_components
dkj Nov 24, 2023
0d7b02d
Merge pull request #772 from mgcam/merge_by_library
dkj Nov 27, 2023
16b062b
Merge remote-tracking branch 'upstream/master' into devel
jmtcsngr Nov 27, 2023
c0ca4eb
Added records for undocumented changed.
mgcam Nov 27, 2023
9b85eee
Merge pull request #780 from mgcam/update_changes_file
jmtcsngr Nov 27, 2023
58e62c7
Fixed incorrect string comparison
mgcam Nov 27, 2023
ccca100
Merge pull request #782 from mgcam/move_runfolder_bug_fix
jmtcsngr Nov 28, 2023
cfa886a
Correct propagation of the CI target branch.
mgcam Nov 28, 2023
f4dd641
Get the branch name correctly, log the branch name.
mgcam Nov 28, 2023
4151537
Merge pull request #783 from mgcam/branch_propagation_in_ci
jmtcsngr Nov 29, 2023
7758a00
prep release 98.0.0
jmtcsngr Nov 30, 2023
13949cb
Merge pull request #785 from jmtcsngr/devel
jmtcsngr Nov 30, 2023
5fc74b2
Merge pull request #786 from wtsi-npg/devel
jmtcsngr Nov 30, 2023
43f3189
Tests reorganised and file reformatted.
mgcam Nov 28, 2023
6e3d718
Converted tabs to spaces
mgcam Nov 30, 2023
d5f29af
Added a method to retrieve modification revision.
mgcam Nov 24, 2023
5f928b7
Retrieve DRAGEN version from instrument record.
mgcam Dec 1, 2023
0d1bc68
Merge pull request #779 from mgcam/dragen_version
dkj Dec 1, 2023
473312d
prep release 98.1.0
jmtcsngr Dec 1, 2023
081e95c
Merge pull request #787 from jmtcsngr/devel
jmtcsngr Dec 1, 2023
e81e6e7
Merge pull request #788 from wtsi-npg/devel
jmtcsngr Dec 1, 2023
c96f724
Updated branch for dependencies on push.
mgcam Dec 4, 2023
88d7bbc
Generalised auto-generator for samplesheets.
mgcam Dec 5, 2023
0d9dbf9
Removed provisions for XML driver in samplesheet generation.
mgcam Dec 5, 2023
7b90a0f
Merge pull request #791 from mgcam/remove_provisions4xml_driver
kjsanger Dec 6, 2023
90e3a07
Removed unused test data.
mgcam Dec 6, 2023
823584a
Merge pull request #792 from mgcam/drop_unused_test_data
jmtcsngr Dec 6, 2023
7baef57
Tested the content of NovaSeqX samplesheet.
mgcam Dec 6, 2023
ed9b189
Merge pull request #790 from mgcam/generalise_samplesheet_daemon
dkj Dec 7, 2023
e63a39e
Merge pull request #793 from mgcam/tests4samplesheet_generation_novaseqx
jmtcsngr Dec 8, 2023
7b3e06e
Improved samplesheet generation for NovaSeqX.
mgcam Dec 15, 2023
8595536
Improved documentation as advised by @jmtcsngr
mgcam Dec 18, 2023
dbf9dd5
Merge pull request #794 from mgcam/novaseqx_ssheet_generator_refactor
jmtcsngr Dec 19, 2023
6ad9feb
Added ability to set path for NovaSeqX ssheet.
mgcam Dec 15, 2023
5aa5005
Simplifies the default samplesheet path.
mgcam Dec 18, 2023
8a0efa3
Small improvements following the code review
mgcam Dec 20, 2023
c496c98
Merge pull request #795 from mgcam/novaseqx_ssheet_path
jmtcsngr Dec 20, 2023
daeb7d9
Samplesheet daemon extension for NovaSeqX
mgcam Dec 18, 2023
5755c97
Added a script to generate samplesheets for pending NovaSeqX runs
mgcam Dec 19, 2023
7337e99
Supressed variant calling.
mgcam Dec 19, 2023
58ce63d
Supressed keeping interim fastq files
mgcam Dec 19, 2023
3caa2ab
Propagated driver details for mlwh driver
mgcam Dec 20, 2023
68fc045
Tested objects created with the rpt_list args.
mgcam Jan 2, 2024
c69e19f
Fixed driver details propagation in create_lane_object method
mgcam Jan 2, 2024
50a9eda
Moved tests for creating tag zero object.
mgcam Jan 3, 2024
7f1213a
Fixed driver details propagation in create_tag_zero_object method
mgcam Jan 3, 2024
de55a4b
Updated aggregate_xlanes method
mgcam Jan 3, 2024
a201104
Removed st::api::lims batch_id constructor arg.
mgcam Jan 4, 2024
770e6a1
Better phrasing
mgcam Jan 4, 2024
9a2c9f0
Ability to derive id_run from a run record
mgcam Jan 4, 2024
c2d8a58
Merge pull request #797 from mgcam/lims_driver_patch
dkj Jan 5, 2024
be4b819
Merge pull request #798 from mgcam/drop_batch_id
jmtcsngr Jan 9, 2024
1c8b653
Merge pull request #796 from mgcam/daemon4novaseqx_samplesheet
jmtcsngr Jan 9, 2024
cc116b6
Recorded recent changes
mgcam Jan 9, 2024
6e02d26
Merge pull request #800 from mgcam/changes_list_update
jmtcsngr Jan 10, 2024
58f3d5f
update signature and iRODS documentation link
jmtcsngr Jan 17, 2024
ec53497
use https for tracking urls in emails
jmtcsngr Jan 18, 2024
fd8ccbe
remove illumina lane qc link from emails
jmtcsngr Jan 17, 2024
7c22caa
Merge remote-tracking branch 'mg8/further_ci_fixes' into throwaway
jmtcsngr Jan 20, 2024
c8b0998
throwaway
jmtcsngr Jan 20, 2024
4aaa13e
to_jmtcsngr
jmtcsngr Jan 20, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 3 additions & 3 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ jobs:
env:
PERL_CACHE: ~/perl5 # Perlbrew and CPAN modules installed here, cached
NPG_LIB: ~/perl5npg # NPG modules installed here, not cached
WTSI_NPG_GITHUB_URL: https://github.com/wtsi-npg
WTSI_NPG_BUILD_BRANCH: ${GITHUB_HEAD_REF}

WSI_NPG_GITHUB_URL: https://github.com/jmtcsngr
WSI_NPG_BUILD_BRANCH: ${{ github.base_ref}}
WSI_NPG_GITHUB_REPO_OWNER: ${{ github.repository_owner }}

strategy:
matrix:
Expand Down
1 change: 0 additions & 1 deletion Build.PL
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ my $builder = $class->new(
'base' => '2.12',
'Carp' => '1.04',
'CGI' => '3.52',
'Class::Accessor' => '0.31',
'Class::Load' => 0,
'Class::Std' => '0.0.8',
'ClearPress' => '>= 473.3.3',
Expand Down
74 changes: 74 additions & 0 deletions Changes
Original file line number Diff line number Diff line change
@@ -1,5 +1,79 @@
LIST OF CHANGES

- st::api::lims
- Removed batch_id constructor argument. It was used by the xml driver,
it is no longer required.
- Fix a bug in propagating driver details to children to ensure that
(1) a switch of the driver type does not happen;
(2) the database handle and the flowcell ID are passed to children
consistently.
- Removed provisions for the xml st::api::lims driver from the old samplesheet
generator npg::samplesheet.
- To avoid code repetitions, created a parent class for different samplesheet
generators and moved common code there.
- Extended the code for the samplesheet daemon to generate samplesheets for
NovaSeqX instruments.
- Removed remaining unused test data from the era of xml st::api::lims driver.
- Updated signature and iRODS documentation link in template for emails
- Updated NPG tracking url to https protocol and port for links in emails
- Removed link to illumina/runs qc page in emails reporting status change event
to subscribers

release 98.1.0
- Added a new method, latest_revision_for_modification, to
npg_tracking::Schema::Result::Instrument to retrieve the latest modification
revision for the instrument.
- Added 'dragen_software_version' script argument
for bin/npg_samplesheet_generator_NovaSeqXSeries. If not set and
id_run is defined, defaults to the record for the latest 'Dragen'
modification for the NovaSeqX instrument on which the flowcell will be
sequenced.

release 98.0.0
- Removed the use of 'xml' lims driver from all tests.
- Deleted 'xml' lims driver class and all classes which supported this
functionality, together with all related tests and test data.
- In release 97.0.0, the default LIMS driver type in samplesheet generation
was changed to 'ml_warehouse'. Following this change, the code for
auto-generation of MiSeq default samplesheets is now simplified to exclude
an explicit creation of LIMS objects.
- Changes to st::api::lims, which are not related to the 'xml' lims driver
removal:
- deleted all previously deprecated methods ('seq_qc_state',
'associated_lims', 'associated_child_lims', 'associated_child_lims_ia');
- deleted methods for which we do not have data in ml warehouse, our
primary source of LIMS data ('request_id', 'project_id', 'project_name');
- deleted all code for computing inline tag indexes and inferring
tag sequences and library types from sample description since
definitions like this have not been in use for the last six years;
- reimplemented the 'reference_genome' method to exclude a fallback to
a study reference for tag zero and lane-level objects when samples
have different references;
- ensured 'required_insert_size' method works correctly for objects that
are initialised with the 'rpt_list' attribute, ie have the 'position'
attribute undefined;
- added 'aggregate_libraries' method, which is similar to the existing
'aggregate_xlanes' method, but instead of getting an instruction to
merge libraries, discovers the libraries which can be merged and returns
a list of merged entities and, separately, a list of singletons.
- npg_tracking::illumina::run::long_info role:
- restricted the 'all_lanes_mergeable' flag to NovaSeq Standard workflow,
ie dropped an additional case of HiSeq Rapid Run since HiSeq instruments
are no longer in use;
- ensured the detection of NovaSeqX and NovaSeq instrument types is
unambiguous.
- Updated DBIx classes from the prod database. Changes are due to the MySQL
database server upgrade to v8.+
- Finding the runfolder path - stopped errors being raised when a runfolder
is found in 'analysis' or 'outgoing' in the presence of a duplicate runfolder
in 'incoming' (the duplicates in 'incoming' are sometimes created by
instruments well after the run was mirrored and the runfolder moved to
'analysis'). The duplicate runfolder in 'incoming' is disregarded'.
- DRAGEN samplesheet generation - limit analysis to human samples only.
- Fixed incorrect string comparison in the npg_move_runfolder script.
- Ensure that pull requests to the master branch source dependencies from
master branches (devel branch was hardcoded).

release 97.0.2
- pin DBD::mysql to 4.050 to keep temp support for old mysql clients

Expand Down
Loading