Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Zabbix Output. #103

Merged
merged 2 commits into from
May 11, 2017
Merged

Conversation

dd00f
Copy link
Contributor

@dd00f dd00f commented May 11, 2017

No description provided.

Copy link
Member

@cyrille-leclerc cyrille-leclerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @dd00f . The code is a pleasure to read.

I have noticed a "typo" on an "@author" anchor, feel free to fix it or I'll merge immediately

* public TcpLineServer server = new TcpLineServer();
* }</pre>
*
* @author Kristoffer Erlandsson
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Kristoffer Erlandsson" -> "Steve McDuff"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. That code was inspired by the Graphite testing code. I made the change.

@cyrille-leclerc cyrille-leclerc merged commit 0ef95eb into jmxtrans:master May 11, 2017
@cyrille-leclerc
Copy link
Member

Thanks @dd00f !

@ggrandes
Copy link
Contributor

ggrandes commented May 6, 2020

This [close #102]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants