Fix xarray's FutureWarning about Dataset.dims (capytaine#451)

jnvn7 · Jan 3, 2024 · f5f0b9f · f5f0b9f
1 parent a0e5730
commit f5f0b9f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/capytaine/io/xarray.py b/capytaine/io/xarray.py
@@ -62,7 +62,7 @@ def problems_from_dataset(dataset: xr.Dataset,
         "All bodies should have different names."
 
     # Warn user in case of key with unrecognized name (e.g. misspells)
-    keys_in_dataset = set(dataset.dims.keys())
+    keys_in_dataset = set(dataset.dims)
     accepted_keys = {'wave_direction', 'radiating_dof', 'influenced_dof',
                      'body_name', 'omega', 'period', 'wavelength', 'wavenumber',
                      'water_depth', 'rho', 'g'}

diff --git a/docs/changelog.rst b/docs/changelog.rst
@@ -74,6 +74,8 @@ Internals
 
 * The `delete_first_lru_cache` decorator has been renamed :func:`~capytaine.tools.lru_cache.lru_cache_with_strict_maxsize` and now supports keyword arguments in the memoized function (:pull:`442`).
 
+* Fix Xarray future warning about `Dataset.dims` (:issue:`450` and :pull:`451`).
+
 * Improve some warnings and error messages.
 
 -------------------------------
-Original file line number
+Diff line change
@@ Expand Up / @@ -74,6 +74,8 @@ Internals @@
     * The `delete_first_lru_cache` decorator has been renamed :func:`~capytaine.tools.lru_cache.lru_cache_with_strict_maxsize` and now supports keyword arguments in the memoized function (:pull:`442`).
+    * Fix Xarray future warning about `Dataset.dims` (:issue:`450` and :pull:`451`).
     * Improve some warnings and error messages.
     -------------------------------
@@ Expand Down @@