Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: contract and abi #15

Merged
merged 10 commits into from
Mar 22, 2024
Merged

add: contract and abi #15

merged 10 commits into from
Mar 22, 2024

Conversation

juroberttyb
Copy link
Collaborator

@juroberttyb juroberttyb commented Mar 22, 2024

This PR

  • Add solidity code of dao contract
  • Add abi of the dao contract
  • Update deployment config json
  • Add a few more deploy config on other networks

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features
    • Introduced a Decentralized Autonomous Organization (DAO) smart contract to manage members, roles, and interactions within the DAO.
    • Added a README section outlining tasks, including a deploy script and unit tests.

Copy link
Contributor

coderabbitai bot commented Mar 22, 2024

Warning

Rate Limit Exceeded

@juroberttyb has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 8 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between fe09a9c and 8444fc7.

Walkthrough

The update introduces a Solidity smart contract dao.sol for Decentralized Autonomous Organizations (DAOs), enabling streamlined governance and interaction processes. It facilitates member management, role assignments, and rating interactions within the DAO, enhancing collective decision-making efficiency.

Changes

File Path Change Summary
smart-contracts/dao.sol Introduced a new Solidity smart contract for DAO management, including member management, role assignments, and rating interactions.
smart-contracts/README.md Added tasks for Hardhat deploy script and unit tests.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

netlify bot commented Mar 22, 2024

Deploy Preview for radical-dao-transparency canceled.

Name Link
🔨 Latest commit 8444fc7
🔍 Latest deploy log https://app.netlify.com/sites/radical-dao-transparency/deploys/65fd80113446850007c67acc

@juroberttyb juroberttyb changed the title add: contract and abi Work In Progress: Add: contract and abi Mar 22, 2024
juroberttyb and others added 2 commits March 22, 2024 20:00
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link
Collaborator Author

@juroberttyb juroberttyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently not adding event.

@juroberttyb juroberttyb requested review from jo-elimu and dalaoqi March 22, 2024 12:05
mapping(string => bool) public hasRole;

constructor() {
members.push(msg.sender);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
members.push(msg.sender);

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Constructer removed.


// roles of a given dao member
string[] public roles;
mapping(string => bool) public hasRole;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mapping(string => bool) public hasRole;
mapping(string => bool) public roleExists;

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated as suggested.

Copy link
Owner

@jo-elimu jo-elimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggestions

@juroberttyb juroberttyb requested a review from jo-elimu March 22, 2024 12:40
@juroberttyb juroberttyb changed the title Work In Progress: Add: contract and abi add: contract and abi Mar 22, 2024
Comment on lines 1 to 3
### TODO
- hardhat deploy script
- unit test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TODO list mentions the need for a hardhat deploy script and unit tests.

Would you like assistance in implementing these tasks? Additionally, it might be beneficial to open GitHub issues to track the progress of these tasks. Shall I proceed with creating them?

@juroberttyb juroberttyb merged commit ff89fc3 into main Mar 22, 2024
8 checks passed
@juroberttyb juroberttyb deleted the add_contract branch March 22, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants