Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC add explanation on the name loky in README #276

Merged
merged 1 commit into from
Jan 7, 2021
Merged

DOC add explanation on the name loky in README #276

merged 1 commit into from
Jan 7, 2021

Conversation

tomMoral
Copy link
Collaborator

@tomMoral tomMoral commented Jan 7, 2021

Add some explanation on why loky.

Closes #274

ogrisel
ogrisel approved these changes Jan 7, 2021
View reviewed changes
Copy link
Collaborator

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good summary, thanks

@ogrisel ogrisel mentioned this pull request Jan 7, 2021
Merged
@ogrisel
Copy link
Collaborator

ogrisel commented Jan 7, 2021

The crash in the test is weird. I do not understand what's happening when reading the logs.

@ogrisel ogrisel mentioned this pull request Jan 7, 2021
Open
@ogrisel
Copy link
Collaborator

ogrisel commented Jan 7, 2021

I opened #278 to improve the test and #279 to track the issue itself.

I think we can merge this doc update.

@ogrisel ogrisel merged commit 4cec662 into joblib:master Jan 7, 2021
@tomMoral tomMoral deleted the DOC_add_name_explanation branch January 7, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reason for name loky
2 participants
@tomMoral @ogrisel