Hide title in list and reader when blank (#813)

jocmp · Feb 4, 2025 · d6a4913 · d6a4913
1 parent 2cca1ce
commit d6a4913
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 9 deletions.
diff --git a/app/src/main/java/com/capyreader/app/ui/articles/ArticleRow.kt b/app/src/main/java/com/capyreader/app/ui/articles/ArticleRow.kt
@@ -104,10 +104,12 @@ fun ArticleRow(
         ) {
             ArticleListItem(
                 headlineContent = {
-                    Text(
-                        article.title,
-                        fontWeight = FontWeight.Bold,
-                    )
+                    if (article.title.isNotBlank()) {
+                        Text(
+                            article.title,
+                            fontWeight = FontWeight.Bold,
+                        )
+                    }
                 },
                 overlineContent = {
                     Row(

diff --git a/capy/src/main/java/com/jocmp/capy/articles/ArticleRenderer.kt b/capy/src/main/java/com/jocmp/capy/articles/ArticleRenderer.kt
@@ -29,7 +29,7 @@ class ArticleRenderer(
 
         val substitutions = colors + mapOf(
             "external_link" to article.externalLink(),
-            "title" to article.title,
+            "title" to title(article.title),
             "byline" to byline,
             "feed_name" to article.feedName,
             "font_size" to "${textSize.get()}px",
@@ -71,11 +71,23 @@ class ArticleRenderer(
         }
     }
 
+    private fun title(articleTitle: String): String {
+        return if (articleTitle.isBlank()) {
+            ""
+        } else {
+            """
+            <div class="article__title">
+                <h1>${articleTitle}</h1>
+            </div>
+            """.trimIndent()
+        }
+    }
+
     private fun fontPreload(fontFamily: FontOption): String {
         return when (fontFamily) {
             FontOption.SYSTEM_DEFAULT -> ""
             else -> """
-                    <link rel="preload" href="https://appassets.androidplatform.net/res/font/${fontFamily.slug}.ttf" as="font" type="font/ttf" crossorigin>
+                <link rel="preload" href="https://appassets.androidplatform.net/res/font/${fontFamily.slug}.ttf" as="font" type="font/ttf" crossorigin>
                 """.trimIndent()
         }
     }

diff --git a/capy/src/main/res/raw/template.html b/capy/src/main/res/raw/template.html