Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ported from mercurial] JOE prompts the user to create the backup dir if it doesn't exist + minor fix to chddir #11

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

jjjordan
Copy link
Member

@jjjordan jjjordan commented Feb 2, 2024

This is a port of merge request 1 on sourceforge.

User is prompted with y/n on startup to create the backup dir if backup dir is set in the options. Chddir now is a function instead of a macro because chdir has difficulties with going to home (~) directories.

@jjjordan
Copy link
Member Author

jjjordan commented Feb 2, 2024

I've modified the original merge request to: merge latest, reformat to conventions, and reuse canonical to fix chddir behavior.

The open questions, as I see them are:

  1. Do we want this prompt when the editor is opened?
  2. Are we OK with making this specific change to chddir?

EDIT: mkpath needs some work still, since it won't handle ~user properly, but the code there is a little more complicated.
EDIT 2: This has been addressed but relies on the new chddir behavior, which I'm not sure about now. Should consider moving canonical into path.c
EDIT 3: I think prompting to create the backup directory the first time JOE tries to create a backup file would be more consistent with how JOE handles other situations. Moreover, there are already prompts during file save and rarely prompts at startup.

@jjjordan jjjordan added the enhancement New feature or request label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants