Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set aliasify configDir to correct value. #28

Closed
wants to merge 2 commits into from

Conversation

jmm
Copy link

@jmm jmm commented Jan 13, 2015

This fixes the problem illustrated in this example.

remapify is aggregating aliases from all of the patterns, and pointing the aliases to paths relative to process.cwd(), but then passing the src from one of the patterns to aliasify as configDir. To do things the way the plugin is setup to do them, all of the paths the aliases point to need to be relative to the same dir that's passed as aliasify's configDir.

The tests continue to pass after this change, but they also passed before the change when this was broken. How do you suggest going about testing that remapify generates the correct data and configuration for aliasify?

@joeybaker
Copy link
Owner

@jmm Thanks! I really appreciate you being so active on this project – thank you!

Somewhere along the way mocha (or more likely browserify), stopped being a PIA, and this test now runs. Uncomment it and you have a full integration test (I've done this in a branch I'm working on to fix the pipeline changes of browserify). Would that do it for you?

@jmm
Copy link
Author

jmm commented Jan 13, 2015

@joeybaker Thanks, I'll take a look at that test. I might have a lead on a solution to the pipeline issue as discussed in my latest comment on #26.

@joeybaker
Copy link
Owner

@jmm awesome! Thanks for all the work!

@tommoor
Copy link

tommoor commented Mar 6, 2015

Any word on this guys? Just lost over an hour to trying to get remapify to work and this branch ended up fixing it.

@joeybaker
Copy link
Owner

v2 of remapify was just released and aliasify is no longer used. Please give that a try and see if your issue is solved. In the meantime, I'm going to close this PR since it modifies code that is no longer in the project.

@joeybaker joeybaker closed this Mar 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants