Jest test finder can get misled by irrelevant "describe" blocks #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @ktfleming for reporting this. Sorry, I accidentally transformed the issue you reported into a pull request. But anyway. This PR seems to fix it.
Hey, I'm really finding this package useful, thanks for creating it!
I've found that
(test-cockpit-npm-jest--find-current-test)
doesn't handle the following case:If I put point on the line marked
// HERE
and evaluate(test-cockpit-npm-jest--find-current-test)
, the output is"middle foo"
, rather than the expected"outer foo"
. It seems that it's looking for the closest preceding"describe"
viasearch-backward-regexp
, rather than looking for the"describe"
that contains the test at point.I do see you have an open issue #7 for looking into tree-sitter which I imagine could help with this by allowing you to look at only the parent node of the current node.