use azure-sdk-for-net ruleset (microsoft#3608)

Fixes microsoft#3368
johanste · Jun 18, 2024 · bb0bfb8 · bb0bfb8
1 parent 62397e4
commit bb0bfb8
Show file tree

Hide file tree

Showing 10 changed files with 405 additions and 226 deletions.
diff --git a/packages/http-client-csharp/eng/CodeAnalysis.ruleset b/packages/http-client-csharp/eng/CodeAnalysis.ruleset
diff --git a/...ator/Microsoft.Generator.CSharp.ClientModel/src/Providers/MrwSerializationTypeProvider.cs b/...ator/Microsoft.Generator.CSharp.ClientModel/src/Providers/MrwSerializationTypeProvider.cs
@@ -85,7 +85,6 @@ protected override MethodProvider[] BuildConstructors()
                     ctorWithNoParamsExist = true;
                 }
 
-
                 if (!serializationCtorParamsMatch)
                 {
                     // Check if the model constructor parameters match the serialization constructor parameters

diff --git a/...client-csharp/generator/Microsoft.Generator.CSharp.Input/src/InputTypes/OperationKinds.cs b/...client-csharp/generator/Microsoft.Generator.CSharp.Input/src/InputTypes/OperationKinds.cs
@@ -1,7 +1,6 @@
-// Copyright (c) Microsoft Corporation. All rights reserved.
+// Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
-
 using System;
 using System.ComponentModel;
 

diff --git a/packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Configuration.cs b/packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Configuration.cs
@@ -168,7 +168,6 @@ private static string ReadRequiredStringOption(JsonElement root, string option)
             return ReadStringOption(root, option) ?? throw new InvalidOperationException($"Unable to parse required option {option} from configuration.");
         }
 
-
         private static string? ReadStringOption(JsonElement root, string option)
         {
             if (root.TryGetProperty(option, out JsonElement value))

diff --git a/...sharp/generator/Microsoft.Generator.CSharp/src/Expressions/FormattableStringExpression.cs b/...sharp/generator/Microsoft.Generator.CSharp/src/Expressions/FormattableStringExpression.cs
@@ -23,7 +23,6 @@ public FormattableStringExpression(string format, IReadOnlyList<ValueExpression>
             Args = args;
         }
 
-
         private string Format { get; init; }
         private IReadOnlyList<ValueExpression> Args { get; init; }
 

diff --git a/...http-client-csharp/generator/Microsoft.Generator.CSharp/src/Providers/ArgumentProvider.cs b/...http-client-csharp/generator/Microsoft.Generator.CSharp/src/Providers/ArgumentProvider.cs
@@ -81,7 +81,6 @@ protected override MethodProvider[] BuildMethods()
             ];
         }
 
-
         private MethodProvider BuildAssertNull()
         {
             var valueParam = new ParameterProvider("value", $"The value.", _t);

diff --git a/...es/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Shared/StringExtensions.cs b/...es/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Shared/StringExtensions.cs
@@ -84,7 +84,6 @@ public static string ToCleanName(this string name, bool isCamelCase = true)
         [return: NotNullIfNotNull(nameof(name))]
         public static string ToVariableName(this string name) => ToCleanName(name, isCamelCase: false);
 
-
         public static GetPathPartsEnumerator GetPathParts(string? path) => new GetPathPartsEnumerator(path);
 
         public ref struct GetPathPartsEnumerator

diff --git a/...client-csharp/generator/Microsoft.Generator.CSharp/src/Snippets/Snippet.JsonSerializer.cs b/...client-csharp/generator/Microsoft.Generator.CSharp/src/Snippets/Snippet.JsonSerializer.cs
@@ -8,7 +8,6 @@ namespace Microsoft.Generator.CSharp.Snippets
 {
     public static partial class Snippet
     {
-
         public static class JsonSerializer
         {
             public static InvokeStaticMethodExpression Serialize(ValueExpression writer, ValueExpression value, ValueExpression? options = null)

diff --git a/packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Snippets/Snippet.cs b/packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Snippets/Snippet.cs
@@ -19,8 +19,8 @@ internal override void Write(CodeWriter writer)
             }
         }
 
-        public readonly static MethodBodyStatement EmptyStatement = new();
-        public readonly static MethodBodyStatement EmptyLineStatement = new PrivateEmptyLineStatement();
+        public static readonly MethodBodyStatement EmptyStatement = new();
+        public static readonly MethodBodyStatement EmptyLineStatement = new PrivateEmptyLineStatement();
 
         public static ExtensibleSnippets Extensible => CodeModelPlugin.Instance.ExtensibleSnippets;
         public static MethodBodyStatement AsStatement(this IEnumerable<MethodBodyStatement> statements) => statements.ToArray();

diff --git a/...tp-client-csharp/generator/Microsoft.Generator.CSharp/src/SourceInput/SourceInputModel.cs b/...tp-client-csharp/generator/Microsoft.Generator.CSharp/src/SourceInput/SourceInputModel.cs
@@ -146,7 +146,6 @@ private bool TryGetName(ISymbol symbol, [NotNullWhen(true)] out string? name)
 
         private async Task<Compilation?> LoadBaselineContract()
         {
-
             string fullPath;
             string projectFilePath = Path.GetFullPath(Path.Combine(CodeModelPlugin.Instance.Configuration.ProjectDirectory, $"{CodeModelPlugin.Instance.Configuration.Namespace}.csproj"));
             if (!File.Exists(projectFilePath))
-Original file line number
+Diff line change
@@ Expand Up / @@ -85,7 +85,6 @@ protected override MethodProvider[] BuildConstructors() @@
                         ctorWithNoParamsExist = true;
                     }
                     if (!serializationCtorParamsMatch)
                     {
                         // Check if the model constructor parameters match the serialization constructor parameters
@@ Expand Down @@