feature: use cache directory in user folder if possible #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| mock_version_module.version = "1.2.3" | ||
| monkeypatch.setitem(sys.modules, "tldextract._version", mock_version_module) | ||
|
|
||
| assert get_pkg_unique_identifier() == "3.8.1.final__myvirtualenv__f01a7b__tldextract-1.2.3" |
There was a problem hiding this comment.
it's a md5 hash of sys.prefix. not sure a better way?
Follows the XDG Base Directory Specification https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html Falls back to attempting to use package directory if it can't determine and XDG directory location.
brycedrennan
force-pushed
the
xdg_cache
branch
from
b5524ce to
77e9f0a
Compare
|
@john-kurkowski ready for review again |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Nov 29, 2020
https://build.opensuse.org/request/show/851574 by user mia + dimstar_suse - Update to 3.1.0: * Features + Prefer to cache in XDG cache directory in user folder, vs. in Python install folder (john-kurkowski/tldextract#213) + Fix `AttributeError` on `--update` (john-kurkowski/tldextract#215)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
okay here is an attempt at using the xdg folder. Addresses #212
While I'm not aware of any issues with this implementation I'm wary of the last changes and their unintended consequences. Could be good to sit on this for a few days
Follows the XDG Base Directory Specification
https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html
Falls back to attempting to use package directory if it can't determine and XDG directory location.