Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#52217 - Refresh PR and update PHPStan #4

Conversation

justlevine
Copy link

Trac ticket: https://core.trac.wordpress.org/ticket/52217

This PR refreshes WordPress#853 by:

  • Merging in trunk
  • Updating PHPStan to the latest v1.12.7
  • Removing now-unmatched errors from phpstan.neon.dist's ignoreErrors list.

Note: I did a squash merge, but if you prefer a traditional merge, I can redo it (the merge conflicts were few and very basic).


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

Report too large to display inline

View full report↗︎

@johnbillion
Copy link
Owner

@justlevine Not sure what's up with this PR but there's 4,000 changed files. I would love to get these fixes in but I won't personally have time for it any time soon so it would be best to open a new PR against the wordpress repo rather than my fork. Cheers!

@justlevine
Copy link
Author

Thanks @johnbillion - will do 🙏

@justlevine justlevine deleted the feature/phpstan/refresh branch November 19, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants