PageNumber support margin top/left

[zirain]

Description

add a new filed MarginTop in PageNumber which help on issues #495

Related Issue

#495

Checklist

check with "x", ONLY IF APPLIED to your change

• All methods associated with structs has func (<first letter of struct> *struct) method() {} name style.
• Wrote unit tests for new/changed features.
• Followed the unit test when,should naming pattern.
• All mocks created with m := mocks.NewConstructor(t).
• All mocks using m.EXPECT().MethodName() method to mock methods.
• Updated docs/doc.go and docs/*
• Updated example_test.go.
• Updated README.md
• New public methods/structs/interfaces has comments upside them explaining they responsibilities
• Executed make dod with none issues pointed out by golangci-lint

[Fernando-hub527]

Hello, I noticed that there are just a few changes left to finalize the PR, and I believe they won't be very complex:

Currently, when the pageNumber is added to the PDF using the provider.AddText method, the method ensures that the text position does not exceed the cell limits (page dimensions minus margins). While this behavior is necessary in many situations, it prevents the pageNumber from being freely positioned.

To address this, I suggest creating a new AddPageNumber method in the provider, similar to AddText. However, this method should specifically limit the text position by the page dimensions instead of cell boundaries.

If you need any help implementing this suggestion, I'm happy to assist.

[codecov]

Codecov Report

Attention: Patch coverage is 73.77049% with 16 lines in your changes missing coverage. Please review.

Project coverage is 88.88%. Comparing base (6923857) to head (aa18fc2).

Files with missing lines	Patch %	Lines
internal/providers/gofpdf/text.go	65.96%	16 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #502      +/-   ##
==========================================
+ Coverage   87.94%   88.88%   +0.94%     
==========================================
  Files          61       61              
  Lines        2330     2347      +17     
==========================================
+ Hits         2049     2086      +37     
+ Misses        246      215      -31     
- Partials       35       46      +11     

Flag	Coverage Δ
unittests	88.88% <73.78%> (+0.94%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Fernando-hub527]

The changes were almost correct, but for them to work, the addPageNumber method should bypass the validations made here. Instead of creating a new AddPageNumber method, I added a parameter to the addText method that allows you to define whether the text position should respect the page margins or not.

This is result:

[zirain]

@Fernando-hub527 thanks for the help.

[zirain]

@Fernando-hub527 can we merge this?

[Fernando-hub527]

@Fernando-hub527 can we merge this?

Hi, the merge is done by @johnfercher , I believe he will soon be checking the pr



[zirain]

kindly ping @johnfercher