added 1,281 actors #135
Closed
added 1,281 actors #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used my tool ( see johnmurphy01#133 ) to automatically create files for each actor that is listed for a movie and does not have a file in the database. NOTE: In some cases, there is not a lot of information on the actor, and the birth date and birth place cannot be determined. In these cases, birthplace and birthdate are listed as null. Fixes: johnmurphy01#130
|
This is extremely awesome of you to do! I will test this out and review it more closely. I would like to figure out some unit tests for this. For instance, ensuring that pulling from wikipedia does indeed pull the birthname. You have a fallback to just use the actor's name, but it would be nice to be able to somewhat verify that the method is doing its job properly |
Closed
|
I have tested it thoroughly today, and after fixing some bugs, I can say with certainty that it is accurate. If the person has a birthname listed on Wikipedia, it will grab it. I understand that you have to test it, just letting you know :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used my tool ( see #133 ) to automatically create files for each actor
that is listed for a movie and does not have a file in the database.
NOTE: In some cases, there is not a lot of information on the actor, and
the birth date and birth place cannot be determined. In these cases,
birthplaceandbirthdateare listed as null.Fixes: #130