Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlockQuote -> BlockTypeQuote, BlockCallout -> BlockTypeCallout. #182

Merged
merged 1 commit into from
Nov 17, 2024
Merged

BlockQuote -> BlockTypeQuote, BlockCallout -> BlockTypeCallout. #182

merged 1 commit into from
Nov 17, 2024

Conversation

amberpixels
Copy link
Contributor

Consistency is the king.

Let's have all BlockType constants to be prefixed with BlockType prefix.

BlockTypeQuote, BlockTypeCallout

jomei
jomei approved these changes Nov 17, 2024
View reviewed changes
Copy link
Owner

@jomei jomei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👑

@jomei jomei merged commit 6609d69 into jomei:main Nov 17, 2024
1 check passed
@amberpixels amberpixels mentioned this pull request Dec 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jomei jomei jomei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amberpixels @jomei