Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pressure): add inches of water and inches of mercury units #729

Merged
merged 2 commits into from
Feb 19, 2025
Merged

feat(pressure): add inches of water and inches of mercury units #729

merged 2 commits into from
Feb 19, 2025
+24 −6

Conversation

jonahsnider
Copy link
Owner

Closes #726

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 19, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #729 will degrade performances by 10.25%

Comparing in-aq-and-in-hg (df9f42f) with main (a9f9990)

Summary

❌ 1 (👁 1) regressions
✅ 5 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
👁 convert 8192 bytes to best 61 µs 67.9 µs -10.25%

@jonahsnider jonahsnider merged commit 534fe1c into main Feb 19, 2025
7 checks passed
@jonahsnider jonahsnider deleted the in-aq-and-in-hg branch February 19, 2025 20:53
@github-actions github-actions bot mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Additional Pressure Conversions
1 participant
@jonahsnider